Driver Test Base issue

[Sachin Goel]

There appears to be some issue in DriverTestBase. I have observed two
failures recently, once in MatchTaskTest and MapTaskTest, both with the
following trace:


Exception in thread "Thread-154" java.lang.AssertionError: Canceling task
failed: java.lang.NullPointerException
at
org.apache.flink.runtime.operators.testutils.DriverTestBase.cancel(DriverTestBase.java:271)
at
org.apache.flink.runtime.operators.testutils.TaskCancelThread.run(TaskCancelThread.java:60)

at org.junit.Assert.fail(Assert.java:88)
at
org.apache.flink.runtime.operators.testutils.TaskCancelThread.run(TaskCancelThread.java:68)

Regards
Sachin

-- Sachin Goel
Computer Science, IIT Delhi
m. [phone]

[mxm]

Hi Sachin,

Thanks for reporting. Which of the test cases failed in the MapTaskTest and
the MatchTaskTest?

Best,
Max

On Tue, Aug 18, 2015 at 5:35 PM, Sachin Goel <[hidden email]>
wrote:

> There appears to be some issue in DriverTestBase. I have observed two
> failures recently, once in MatchTaskTest and MapTaskTest, both with the
> following trace:
>
>
> Exception in thread "Thread-154" java.lang.AssertionError: Canceling task
> failed: java.lang.NullPointerException
> at
>
> org.apache.flink.runtime.operators.testutils.DriverTestBase.cancel(DriverTestBase.java:271)
> at
>
> org.apache.flink.runtime.operators.testutils.TaskCancelThread.run(TaskCancelThread.java:60)
>
> at org.junit.Assert.fail(Assert.java:88)
> at
>
> org.apache.flink.runtime.operators.testutils.TaskCancelThread.run(TaskCancelThread.java:68)
>
> Regards
> Sachin
>
> -- Sachin Goel
> Computer Science, IIT Delhi
> m. [phone]
>

... [show rest of quote]

[Sachin Goel]

Hi Max
I have already created a Jira for this.
https://issues.apache.org/jira/browse/FLINK-2528
The failing test was testCancelMatchTaskWhileMatching(), but I think it has
more to do with the failure in canceling in general. I'll point you to some
build logs. It might take me some time to find them since I've triggered
quite a few builds since my email.

​Cheers!
Sachin​

-- Sachin Goel
Computer Science, IIT Delhi
m. [phone]

On Mon, Aug 24, 2015 at 3:38 PM, Maximilian Michels <[hidden email]> wrote:

> Hi Sachin,
>
> Thanks for reporting. Which of the test cases failed in the MapTaskTest and
> the MatchTaskTest?
>
> Best,
> Max
>
> On Tue, Aug 18, 2015 at 5:35 PM, Sachin Goel <[hidden email]>
> wrote:
>
> > There appears to be some issue in DriverTestBase. I have observed two
> > failures recently, once in MatchTaskTest and MapTaskTest, both with the
> > following trace:
> >
> >
> > Exception in thread "Thread-154" java.lang.AssertionError: Canceling task
> > failed: java.lang.NullPointerException
> > at
> >
> >
> org.apache.flink.runtime.operators.testutils.DriverTestBase.cancel(DriverTestBase.java:271)
> > at
> >
> >
> org.apache.flink.runtime.operators.testutils.TaskCancelThread.run(TaskCancelThread.java:60)
> >
> > at org.junit.Assert.fail(Assert.java:88)
> > at
> >
> >
> org.apache.flink.runtime.operators.testutils.TaskCancelThread.run(TaskCancelThread.java:68)
> >
> > Regards
> > Sachin
> >
> > -- Sachin Goel
> > Computer Science, IIT Delhi
> > m. [phone]
> >
>

... [show rest of quote]

[Stephan Ewen]

Looking into this. Seems like a wrong use of assertions in a parallel
thread, where errors are not propagated to the main JUNit thread.

On Mon, Aug 24, 2015 at 6:53 PM, Sachin Goel <[hidden email]>
wrote:

> Hi Max
> I have already created a Jira for this.
> https://issues.apache.org/jira/browse/FLINK-2528
> The failing test was testCancelMatchTaskWhileMatching(), but I think it has
> more to do with the failure in canceling in general. I'll point you to some
> build logs. It might take me some time to find them since I've triggered
> quite a few builds since my email.
>
> ​Cheers!
> Sachin​
>
> -- Sachin Goel
> Computer Science, IIT Delhi
> m. [phone]
>
> On Mon, Aug 24, 2015 at 3:38 PM, Maximilian Michels <[hidden email]>
> wrote:
>
> > Hi Sachin,
> >
> > Thanks for reporting. Which of the test cases failed in the MapTaskTest
> and
> > the MatchTaskTest?
> >
> > Best,
> > Max
> >
> > On Tue, Aug 18, 2015 at 5:35 PM, Sachin Goel <[hidden email]>
> > wrote:
> >
> > > There appears to be some issue in DriverTestBase. I have observed two
> > > failures recently, once in MatchTaskTest and MapTaskTest, both with the
> > > following trace:
> > >
> > >
> > > Exception in thread "Thread-154" java.lang.AssertionError: Canceling
> task
> > > failed: java.lang.NullPointerException
> > > at
> > >
> > >
> >
> org.apache.flink.runtime.operators.testutils.DriverTestBase.cancel(DriverTestBase.java:271)
> > > at
> > >
> > >
> >
> org.apache.flink.runtime.operators.testutils.TaskCancelThread.run(TaskCancelThread.java:60)
> > >
> > > at org.junit.Assert.fail(Assert.java:88)
> > > at
> > >
> > >
> >
> org.apache.flink.runtime.operators.testutils.TaskCancelThread.run(TaskCancelThread.java:68)
> > >
> > > Regards
> > > Sachin
> > >
> > > -- Sachin Goel
> > > Computer Science, IIT Delhi
> > > m. [phone]
> > >
> >
>

... [show rest of quote]

[Stephan Ewen]

Test for a fix is pending...

On Tue, Aug 25, 2015 at 1:30 PM, Stephan Ewen <[hidden email]> wrote:

> Looking into this. Seems like a wrong use of assertions in a parallel
> thread, where errors are not propagated to the main JUNit thread.
>
> On Mon, Aug 24, 2015 at 6:53 PM, Sachin Goel <[hidden email]>
> wrote:
>
>> Hi Max
>> I have already created a Jira for this.
>> https://issues.apache.org/jira/browse/FLINK-2528
>> The failing test was testCancelMatchTaskWhileMatching(), but I think it
>> has
>> more to do with the failure in canceling in general. I'll point you to
>> some
>> build logs. It might take me some time to find them since I've triggered
>> quite a few builds since my email.
>>
>> ​Cheers!
>> Sachin​
>>
>> -- Sachin Goel
>> Computer Science, IIT Delhi
>> m. [phone]
>>
>> On Mon, Aug 24, 2015 at 3:38 PM, Maximilian Michels <[hidden email]>
>> wrote:
>>
>> > Hi Sachin,
>> >
>> > Thanks for reporting. Which of the test cases failed in the MapTaskTest
>> and
>> > the MatchTaskTest?
>> >
>> > Best,
>> > Max
>> >
>> > On Tue, Aug 18, 2015 at 5:35 PM, Sachin Goel <[hidden email]>
>> > wrote:
>> >
>> > > There appears to be some issue in DriverTestBase. I have observed two
>> > > failures recently, once in MatchTaskTest and MapTaskTest, both with
>> the
>> > > following trace:
>> > >
>> > >
>> > > Exception in thread "Thread-154" java.lang.AssertionError: Canceling
>> task
>> > > failed: java.lang.NullPointerException
>> > > at
>> > >
>> > >
>> >
>> org.apache.flink.runtime.operators.testutils.DriverTestBase.cancel(DriverTestBase.java:271)
>> > > at
>> > >
>> > >
>> >
>> org.apache.flink.runtime.operators.testutils.TaskCancelThread.run(TaskCancelThread.java:60)
>> > >
>> > > at org.junit.Assert.fail(Assert.java:88)
>> > > at
>> > >
>> > >
>> >
>> org.apache.flink.runtime.operators.testutils.TaskCancelThread.run(TaskCancelThread.java:68)
>> > >
>> > > Regards
>> > > Sachin
>> > >
>> > > -- Sachin Goel
>> > > Computer Science, IIT Delhi
>> > > m. [phone]
>> > >
>> >
>>
>
>

... [show rest of quote]