Hi,
I am working on https://issues.apache.org/jira/browse/FLINK-2111 Stephan and I had a discussion about the name of the signal. See: https://github.com/apache/flink/pull/750 Because we cannot agree on either "terminate" or "stop" we would appreciate some feedback about it. If anybody has an third alternative for the name, please go ahead an share it. -Matthias |
Hi,
thanks for starting this thread! I prefer "stop" over "terminate" because it sounds more graceful. A temporary stop could be called "pause". Cheers, Fabian 2015-06-29 13:42 GMT+02:00 Matthias J. Sax <[hidden email]>: > Hi, > > I am working on https://issues.apache.org/jira/browse/FLINK-2111 > > Stephan and I had a discussion about the name of the signal. See: > https://github.com/apache/flink/pull/750 > > Because we cannot agree on either "terminate" or "stop" we would > appreciate some feedback about it. If anybody has an third alternative > for the name, please go ahead an share it. > > > -Matthias > > |
+1 for "stop"
On Tue, Jun 30, 2015 at 10:26 AM, Fabian Hueske <[hidden email]> wrote: > Hi, > > thanks for starting this thread! > > I prefer "stop" over "terminate" because it sounds more graceful. A > temporary stop could be called "pause". > > Cheers, Fabian > > 2015-06-29 13:42 GMT+02:00 Matthias J. Sax <[hidden email] > >: > > > Hi, > > > > I am working on https://issues.apache.org/jira/browse/FLINK-2111 > > > > Stephan and I had a discussion about the name of the signal. See: > > https://github.com/apache/flink/pull/750 > > > > Because we cannot agree on either "terminate" or "stop" we would > > appreciate some feedback about it. If anybody has an third alternative > > for the name, please go ahead an share it. > > > > > > -Matthias > > > > > |
In reply to this post by Fabian Hueske-2
On 30 Jun 2015, at 10:26, Fabian Hueske <[hidden email]> wrote: > Hi, > > thanks for starting this thread! > > I prefer "stop" over "terminate" because it sounds more graceful. A > temporary stop could be called "pause". +1 to stop. – Ufuk |
Hi Matthias,
+1 for stop, but it's only a name :) The rest of your changes deserve much more attention. Because I have also worked on the ExecutionGraph and also fixed a bug there, I agree with Stephan that we shouldn't change the logic of the state machine. It will lead to very subtle hard to spot bugs. On Tue, Jun 30, 2015 at 10:38 AM, Ufuk Celebi <[hidden email]> wrote: > > On 30 Jun 2015, at 10:26, Fabian Hueske <[hidden email]> wrote: > > > Hi, > > > > thanks for starting this thread! > > > > I prefer "stop" over "terminate" because it sounds more graceful. A > > temporary stop could be called "pause". > > +1 to stop. > > – Ufuk |
+1 for stop, because terminate sounds very harsh
On Tue, 30 Jun 2015 at 10:45 Maximilian Michels <[hidden email]> wrote: > Hi Matthias, > > +1 for stop, but it's only a name :) The rest of your changes deserve much > more attention. Because I have also worked on the ExecutionGraph and also > fixed a bug there, I agree with Stephan that we shouldn't change the logic > of the state machine. It will lead to very subtle hard to spot bugs. > > On Tue, Jun 30, 2015 at 10:38 AM, Ufuk Celebi <[hidden email]> wrote: > > > > > On 30 Jun 2015, at 10:26, Fabian Hueske <[hidden email]> wrote: > > > > > Hi, > > > > > > thanks for starting this thread! > > > > > > I prefer "stop" over "terminate" because it sounds more graceful. A > > > temporary stop could be called "pause". > > > > +1 to stop. > > > > – Ufuk > |
Thanks for your feedback. The vote in clear: "stop" wins
On 06/30/2015 10:51 AM, Aljoscha Krettek wrote: > +1 for stop, because terminate sounds very harsh > > On Tue, 30 Jun 2015 at 10:45 Maximilian Michels <[hidden email]> wrote: > >> Hi Matthias, >> >> +1 for stop, but it's only a name :) The rest of your changes deserve much >> more attention. Because I have also worked on the ExecutionGraph and also >> fixed a bug there, I agree with Stephan that we shouldn't change the logic >> of the state machine. It will lead to very subtle hard to spot bugs. >> >> On Tue, Jun 30, 2015 at 10:38 AM, Ufuk Celebi <[hidden email]> wrote: >> >>> >>> On 30 Jun 2015, at 10:26, Fabian Hueske <[hidden email]> wrote: >>> >>>> Hi, >>>> >>>> thanks for starting this thread! >>>> >>>> I prefer "stop" over "terminate" because it sounds more graceful. A >>>> temporary stop could be called "pause". >>> >>> +1 to stop. >>> >>> – Ufuk >> > |
Free forum by Nabble | Edit this page |