Hi folks,
I thought about renaming the TableEnvironment.toTable() method to TableEnvironment.fromDataSet(). This would be closer to SQL FROM and allow to add other methods like fromCSV(), fromHCat(), fromParquet(), fromORC(), etc. If we decide for the renaming, we should do it before the release. Cheers, Fabian |
+1, then we would of course also rename the other one to "fromDataStream".
On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske <[hidden email]> wrote: > Hi folks, > > I thought about renaming the TableEnvironment.toTable() method to > TableEnvironment.fromDataSet(). > This would be closer to SQL FROM and allow to add other methods like > fromCSV(), fromHCat(), fromParquet(), fromORC(), etc. > > If we decide for the renaming, we should do it before the release. > > Cheers, Fabian |
+1
I didn't know that the Table API supports DataStreams as well. On Fri, Jun 5, 2015 at 10:18 AM, Aljoscha Krettek <[hidden email]> wrote: > +1, then we would of course also rename the other one to "fromDataStream". > > On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske <[hidden email]> wrote: > > Hi folks, > > > > I thought about renaming the TableEnvironment.toTable() method to > > TableEnvironment.fromDataSet(). > > This would be closer to SQL FROM and allow to add other methods like > > fromCSV(), fromHCat(), fromParquet(), fromORC(), etc. > > > > If we decide for the renaming, we should do it before the release. > > > > Cheers, Fabian > |
Of course, everything that doesn't need windows is supported.
On Fri, Jun 5, 2015 at 10:21 AM, Robert Metzger <[hidden email]> wrote: > +1 > > I didn't know that the Table API supports DataStreams as well. > > On Fri, Jun 5, 2015 at 10:18 AM, Aljoscha Krettek <[hidden email]> > wrote: > >> +1, then we would of course also rename the other one to "fromDataStream". >> >> On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske <[hidden email]> wrote: >> > Hi folks, >> > >> > I thought about renaming the TableEnvironment.toTable() method to >> > TableEnvironment.fromDataSet(). >> > This would be closer to SQL FROM and allow to add other methods like >> > fromCSV(), fromHCat(), fromParquet(), fromORC(), etc. >> > >> > If we decide for the renaming, we should do it before the release. >> > >> > Cheers, Fabian >> |
Great!
On Fri, Jun 5, 2015 at 10:24 AM, Aljoscha Krettek <[hidden email]> wrote: > Of course, everything that doesn't need windows is supported. > > On Fri, Jun 5, 2015 at 10:21 AM, Robert Metzger <[hidden email]> > wrote: > > +1 > > > > I didn't know that the Table API supports DataStreams as well. > > > > On Fri, Jun 5, 2015 at 10:18 AM, Aljoscha Krettek <[hidden email]> > > wrote: > > > >> +1, then we would of course also rename the other one to > "fromDataStream". > >> > >> On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske <[hidden email]> > wrote: > >> > Hi folks, > >> > > >> > I thought about renaming the TableEnvironment.toTable() method to > >> > TableEnvironment.fromDataSet(). > >> > This would be closer to SQL FROM and allow to add other methods like > >> > fromCSV(), fromHCat(), fromParquet(), fromORC(), etc. > >> > > >> > If we decide for the renaming, we should do it before the release. > >> > > >> > Cheers, Fabian > >> > |
Thanks everybody,
I will prepare a PR for that. 2015-06-05 10:45 GMT+02:00 Stephan Ewen <[hidden email]>: > Great! > > On Fri, Jun 5, 2015 at 10:24 AM, Aljoscha Krettek <[hidden email]> > wrote: > > > Of course, everything that doesn't need windows is supported. > > > > On Fri, Jun 5, 2015 at 10:21 AM, Robert Metzger <[hidden email]> > > wrote: > > > +1 > > > > > > I didn't know that the Table API supports DataStreams as well. > > > > > > On Fri, Jun 5, 2015 at 10:18 AM, Aljoscha Krettek <[hidden email] > > > > > wrote: > > > > > >> +1, then we would of course also rename the other one to > > "fromDataStream". > > >> > > >> On Fri, Jun 5, 2015 at 10:13 AM, Fabian Hueske <[hidden email]> > > wrote: > > >> > Hi folks, > > >> > > > >> > I thought about renaming the TableEnvironment.toTable() method to > > >> > TableEnvironment.fromDataSet(). > > >> > This would be closer to SQL FROM and allow to add other methods like > > >> > fromCSV(), fromHCat(), fromParquet(), fromORC(), etc. > > >> > > > >> > If we decide for the renaming, we should do it before the release. > > >> > > > >> > Cheers, Fabian > > >> > > > |
Free forum by Nabble | Edit this page |