[DISCUSS] Removing deprecated state methods in 1.11

[Stephan Ewen]

Hi all!

There are a bunch of deprecated methods for state access:

  - RuntimeContext.getFoldingState(...)
  - OperatorStateStore.getSerializableListState(...)
  -  OperatorStateStore.getOperatorState(...)

All of them have been deprecated for around three years now. All have good
alternatives.

Time to remove them in 1.11?

Best,
Stephan

[DONG, Weike]

Hi Stephan,

+1 for the removal, as there are so many deprecated methods scattered
around, making APIs a little bit messy and confusing.

Best,
Weike

Stephan Ewen <[hidden email]>于2020年4月23日 周四下午8:07写道：

> Hi all!
>
> There are a bunch of deprecated methods for state access:
>
>   - RuntimeContext.getFoldingState(...)
>   - OperatorStateStore.getSerializableListState(...)
>   -  OperatorStateStore.getOperatorState(...)
>
> All of them have been deprecated for around three years now. All have good
> alternatives.
>
> Time to remove them in 1.11?
>
> Best,
> Stephan
>

[Aljoscha Krettek-2]

Definitely +1! I'm always game for decreasing the API surface if it
doesn't decrease functionality.

Aljoscha

On 23.04.20 14:18, DONG, Weike wrote:

> Hi Stephan,
>
> +1 for the removal, as there are so many deprecated methods scattered
> around, making APIs a little bit messy and confusing.
>
> Best,
> Weike
>
> Stephan Ewen <[hidden email]>于2020年4月23日 周四下午8:07写道：
>
>> Hi all!
>>
>> There are a bunch of deprecated methods for state access:
>>
>>    - RuntimeContext.getFoldingState(...)
>>    - OperatorStateStore.getSerializableListState(...)
>>    -  OperatorStateStore.getOperatorState(...)
>>
>> All of them have been deprecated for around three years now. All have good
>> alternatives.
>>
>> Time to remove them in 1.11?
>>
>> Best,
>> Stephan
>>
>

[Stephan Ewen]

I'll turn this into a ticket for 1.11 then.

Thanks!

On Thu, Apr 23, 2020 at 4:13 PM Aljoscha Krettek <[hidden email]>
wrote:

> Definitely +1! I'm always game for decreasing the API surface if it
> doesn't decrease functionality.
>
> Aljoscha
>
> On 23.04.20 14:18, DONG, Weike wrote:
> > Hi Stephan,
> >
> > +1 for the removal, as there are so many deprecated methods scattered
> > around, making APIs a little bit messy and confusing.
> >
> > Best,
> > Weike
> >
> > Stephan Ewen <[hidden email]>于2020年4月23日 周四下午8:07写道：
> >
> >> Hi all!
> >>
> >> There are a bunch of deprecated methods for state access:
> >>
> >>    - RuntimeContext.getFoldingState(...)
> >>    - OperatorStateStore.getSerializableListState(...)
> >>    -  OperatorStateStore.getOperatorState(...)
> >>
> >> All of them have been deprecated for around three years now. All have
> good
> >> alternatives.
> >>
> >> Time to remove them in 1.11?
> >>
> >> Best,
> >> Stephan
> >>
> >
>
>

[Yu Li]

+1 (belated), removing long deprecated codes help keep the code base clean
and reduce the maintenance efforts.

Best Regards,
Yu


On Sat, 25 Apr 2020 at 00:45, Stephan Ewen <[hidden email]> wrote:

> I'll turn this into a ticket for 1.11 then.
>
> Thanks!
>
> On Thu, Apr 23, 2020 at 4:13 PM Aljoscha Krettek <[hidden email]>
> wrote:
>
> > Definitely +1! I'm always game for decreasing the API surface if it
> > doesn't decrease functionality.
> >
> > Aljoscha
> >
> > On 23.04.20 14:18, DONG, Weike wrote:
> > > Hi Stephan,
> > >
> > > +1 for the removal, as there are so many deprecated methods scattered
> > > around, making APIs a little bit messy and confusing.
> > >
> > > Best,
> > > Weike
> > >
> > > Stephan Ewen <[hidden email]>于2020年4月23日 周四下午8:07写道：
> > >
> > >> Hi all!
> > >>
> > >> There are a bunch of deprecated methods for state access:
> > >>
> > >>    - RuntimeContext.getFoldingState(...)
> > >>    - OperatorStateStore.getSerializableListState(...)
> > >>    -  OperatorStateStore.getOperatorState(...)
> > >>
> > >> All of them have been deprecated for around three years now. All have
> > good
> > >> alternatives.
> > >>
> > >> Time to remove them in 1.11?
> > >>
> > >> Best,
> > >> Stephan
> > >>
> > >
> >
> >
>