[DISCUSS] Removal of flink-swift-fs-hadoop module

[Robert Metzger]

Hi all,

during a security maintenance PR [1], Chesnay noticed that the
flink-swift-fs-hadoop module is lacking test coverage [2].
Also, there hasn't been any substantial change since 2018, when it was
introduced.
On the user@ ML, I could not find any proof of significant use of the
module (no one mentioned any problems with it).

*I propose to remove this module in Flink 1.13*. Otherwise, we would
release a module with known vulnerable dependencies, and an unknown
stability.
If there are users, they can still use the 1.12.0 release of it. If we
notice that there are a lot of users, we can reintroduce the FS, and add
proper tests for it.

Please let me know if you have any concerns, otherwise, I'll remove it.


[1] https://github.com/apache/flink/pull/14749
[2] https://issues.apache.org/jira/browse/FLINK-20804

[Aljoscha Krettek-2]

+1

I'm almost always in favour of removing old code instead of continuing
to let it rot.

Best,
Aljoscha

On 2021/01/26 14:11, Robert Metzger wrote:

>Hi all,
>
>during a security maintenance PR [1], Chesnay noticed that the
>flink-swift-fs-hadoop module is lacking test coverage [2].
>Also, there hasn't been any substantial change since 2018, when it was
>introduced.
>On the user@ ML, I could not find any proof of significant use of the
>module (no one mentioned any problems with it).
>
>*I propose to remove this module in Flink 1.13*. Otherwise, we would
>release a module with known vulnerable dependencies, and an unknown
>stability.
>If there are users, they can still use the 1.12.0 release of it. If we
>notice that there are a lot of users, we can reintroduce the FS, and add
>proper tests for it.
>
>Please let me know if you have any concerns, otherwise, I'll remove it.
>
>
>[1] https://github.com/apache/flink/pull/14749
>[2] https://issues.apache.org/jira/browse/FLINK-20804

[Chesnay Schepler-3]

+1

While I don't think the filesystem is really useless, in it's current
state it is not maintainable, and so far no one rose up to remedy this.

On 1/27/2021 10:57 AM, Aljoscha Krettek wrote:

> +1
>
> I'm almost always in favour of removing old code instead of continuing
> to let it rot.
>
> Best,
> Aljoscha
>
> On 2021/01/26 14:11, Robert Metzger wrote:
>> Hi all,
>>
>> during a security maintenance PR [1], Chesnay noticed that the
>> flink-swift-fs-hadoop module is lacking test coverage [2].
>> Also, there hasn't been any substantial change since 2018, when it was
>> introduced.
>> On the user@ ML, I could not find any proof of significant use of the
>> module (no one mentioned any problems with it).
>>
>> *I propose to remove this module in Flink 1.13*. Otherwise, we would
>> release a module with known vulnerable dependencies, and an unknown
>> stability.
>> If there are users, they can still use the 1.12.0 release of it. If we
>> notice that there are a lot of users, we can reintroduce the FS, and add
>> proper tests for it.
>>
>> Please let me know if you have any concerns, otherwise, I'll remove it.
>>
>>
>> [1] https://github.com/apache/flink/pull/14749
>> [2] https://issues.apache.org/jira/browse/FLINK-20804

[dwysakowicz]

+1

On 27/01/2021 11:00, Chesnay Schepler wrote:

> +1
>
> While I don't think the filesystem is really useless, in it's current
> state it is not maintainable, and so far no one rose up to remedy this.
>
> On 1/27/2021 10:57 AM, Aljoscha Krettek wrote:
>> +1
>>
>> I'm almost always in favour of removing old code instead of
>> continuing to let it rot.
>>
>> Best,
>> Aljoscha
>>
>> On 2021/01/26 14:11, Robert Metzger wrote:
>>> Hi all,
>>>
>>> during a security maintenance PR [1], Chesnay noticed that the
>>> flink-swift-fs-hadoop module is lacking test coverage [2].
>>> Also, there hasn't been any substantial change since 2018, when it was
>>> introduced.
>>> On the user@ ML, I could not find any proof of significant use of the
>>> module (no one mentioned any problems with it).
>>>
>>> *I propose to remove this module in Flink 1.13*. Otherwise, we would
>>> release a module with known vulnerable dependencies, and an unknown
>>> stability.
>>> If there are users, they can still use the 1.12.0 release of it. If we
>>> notice that there are a lot of users, we can reintroduce the FS, and
>>> add
>>> proper tests for it.
>>>
>>> Please let me know if you have any concerns, otherwise, I'll remove it.
>>>
>>>
>>> [1] https://github.com/apache/flink/pull/14749
>>> [2] https://issues.apache.org/jira/browse/FLINK-20804
>
>

[Ufuk Celebi-2]

+1

On Wed, Jan 27, 2021, at 11:02 AM, Dawid Wysakowicz wrote:

> +1
>
> On 27/01/2021 11:00, Chesnay Schepler wrote:
> > +1
> >
> > While I don't think the filesystem is really useless, in it's current
> > state it is not maintainable, and so far no one rose up to remedy this.
> >
> > On 1/27/2021 10:57 AM, Aljoscha Krettek wrote:
> >> +1
> >>
> >> I'm almost always in favour of removing old code instead of
> >> continuing to let it rot.
> >>
> >> Best,
> >> Aljoscha
> >>
> >> On 2021/01/26 14:11, Robert Metzger wrote:
> >>> Hi all,
> >>>
> >>> during a security maintenance PR [1], Chesnay noticed that the
> >>> flink-swift-fs-hadoop module is lacking test coverage [2].
> >>> Also, there hasn't been any substantial change since 2018, when it was
> >>> introduced.
> >>> On the user@ ML, I could not find any proof of significant use of the
> >>> module (no one mentioned any problems with it).
> >>>
> >>> *I propose to remove this module in Flink 1.13*. Otherwise, we would
> >>> release a module with known vulnerable dependencies, and an unknown
> >>> stability.
> >>> If there are users, they can still use the 1.12.0 release of it. If we
> >>> notice that there are a lot of users, we can reintroduce the FS, and
> >>> add
> >>> proper tests for it.
> >>>
> >>> Please let me know if you have any concerns, otherwise, I'll remove it.
> >>>
> >>>
> >>> [1] https://github.com/apache/flink/pull/14749
> >>> [2] https://issues.apache.org/jira/browse/FLINK-20804
> >
> >
>
>
>
> *Attachments:*
>  * signature.asc

[Till Rohrmann]

+1,

Cheers,
Till

On Wed, Jan 27, 2021 at 11:03 AM Ufuk Celebi <[hidden email]> wrote:

> +1
>
> On Wed, Jan 27, 2021, at 11:02 AM, Dawid Wysakowicz wrote:
> > +1
> >
> > On 27/01/2021 11:00, Chesnay Schepler wrote:
> > > +1
> > >
> > > While I don't think the filesystem is really useless, in it's current
> > > state it is not maintainable, and so far no one rose up to remedy this.
> > >
> > > On 1/27/2021 10:57 AM, Aljoscha Krettek wrote:
> > >> +1
> > >>
> > >> I'm almost always in favour of removing old code instead of
> > >> continuing to let it rot.
> > >>
> > >> Best,
> > >> Aljoscha
> > >>
> > >> On 2021/01/26 14:11, Robert Metzger wrote:
> > >>> Hi all,
> > >>>
> > >>> during a security maintenance PR [1], Chesnay noticed that the
> > >>> flink-swift-fs-hadoop module is lacking test coverage [2].
> > >>> Also, there hasn't been any substantial change since 2018, when it
> was
> > >>> introduced.
> > >>> On the user@ ML, I could not find any proof of significant use of
> the
> > >>> module (no one mentioned any problems with it).
> > >>>
> > >>> *I propose to remove this module in Flink 1.13*. Otherwise, we would
> > >>> release a module with known vulnerable dependencies, and an unknown
> > >>> stability.
> > >>> If there are users, they can still use the 1.12.0 release of it. If
> we
> > >>> notice that there are a lot of users, we can reintroduce the FS, and
> > >>> add
> > >>> proper tests for it.
> > >>>
> > >>> Please let me know if you have any concerns, otherwise, I'll remove
> it.
> > >>>
> > >>>
> > >>> [1] https://github.com/apache/flink/pull/14749
> > >>> [2] https://issues.apache.org/jira/browse/FLINK-20804
> > >
> > >
> >
> >
> >
> > *Attachments:*
> >  * signature.asc

[Robert Metzger]

Thanks a lot for your feedback! It seems that there was no objection to
this proposal.

I filed a ticket for removing the filesystem:
https://issues.apache.org/jira/browse/FLINK-21819

On Wed, Jan 27, 2021 at 2:28 PM Till Rohrmann <[hidden email]> wrote:

> +1,
>
> Cheers,
> Till
>
> On Wed, Jan 27, 2021 at 11:03 AM Ufuk Celebi <[hidden email]> wrote:
>
> > +1
> >
> > On Wed, Jan 27, 2021, at 11:02 AM, Dawid Wysakowicz wrote:
> > > +1
> > >
> > > On 27/01/2021 11:00, Chesnay Schepler wrote:
> > > > +1
> > > >
> > > > While I don't think the filesystem is really useless, in it's current
> > > > state it is not maintainable, and so far no one rose up to remedy
> this.
> > > >
> > > > On 1/27/2021 10:57 AM, Aljoscha Krettek wrote:
> > > >> +1
> > > >>
> > > >> I'm almost always in favour of removing old code instead of
> > > >> continuing to let it rot.
> > > >>
> > > >> Best,
> > > >> Aljoscha
> > > >>
> > > >> On 2021/01/26 14:11, Robert Metzger wrote:
> > > >>> Hi all,
> > > >>>
> > > >>> during a security maintenance PR [1], Chesnay noticed that the
> > > >>> flink-swift-fs-hadoop module is lacking test coverage [2].
> > > >>> Also, there hasn't been any substantial change since 2018, when it
> > was
> > > >>> introduced.
> > > >>> On the user@ ML, I could not find any proof of significant use of
> > the
> > > >>> module (no one mentioned any problems with it).
> > > >>>
> > > >>> *I propose to remove this module in Flink 1.13*. Otherwise, we
> would
> > > >>> release a module with known vulnerable dependencies, and an unknown
> > > >>> stability.
> > > >>> If there are users, they can still use the 1.12.0 release of it. If
> > we
> > > >>> notice that there are a lot of users, we can reintroduce the FS,
> and
> > > >>> add
> > > >>> proper tests for it.
> > > >>>
> > > >>> Please let me know if you have any concerns, otherwise, I'll remove
> > it.
> > > >>>
> > > >>>
> > > >>> [1] https://github.com/apache/flink/pull/14749
> > > >>> [2] https://issues.apache.org/jira/browse/FLINK-20804
> > > >
> > > >
> > >
> > >
> > >
> > > *Attachments:*
> > >  * signature.asc
>