[DISCUSS] Releasing Flink 1.1.2

[Ufuk Celebi-2]

It's been ~2 weeks since we released Flink 1.1.1 and I wanted to start
discussing releasing Flink 1.1.2.

There have been 27 commits in the release-1.1 branch since the
release, including at least one critical issue:

[FLINK-4332] [checkpoints] Fix SavepointV1Serializer read() /
readFully() (2 weeks ago) <Stephan Ewen>

This can lead to savepoints being not deserialized correctly. A user
did already run into this and reported it in FLINK-4425. There are
also other minor user reported issues (like FLINK-4454) that have been
fixed.

What do you think about this? We would need a volunteer for release manager.

– Ufuk

[Gyula Fóra-2]

Hi,

I agree that there has been some critical issues discovered and it would be
to get the fixes out as soon as possible :)

On my side I would like to add the fixes for:
FLINK-4441
FLINK-4471

Both can be critical for applications that use the RocksDB backend.

Gyula

Ufuk Celebi <[hidden email]> ezt írta (időpont: 2016. aug. 24., Sze, 12:25):

> It's been ~2 weeks since we released Flink 1.1.1 and I wanted to start
> discussing releasing Flink 1.1.2.
>
> There have been 27 commits in the release-1.1 branch since the
> release, including at least one critical issue:
>
> [FLINK-4332] [checkpoints] Fix SavepointV1Serializer read() /
> readFully() (2 weeks ago) <Stephan Ewen>
>
> This can lead to savepoints being not deserialized correctly. A user
> did already run into this and reported it in FLINK-4425. There are
> also other minor user reported issues (like FLINK-4454) that have been
> fixed.
>
> What do you think about this? We would need a volunteer for release
> manager.
>
> – Ufuk
>

[Tzu-Li Tai]

Hi Ufuk,

Thanks for bringing up the discussion.

There’s also a critical issue with the Kinesis connector when used with
window operators downstream:
https://issues.apache.org/jira/browse/FLINK-4341. This leads to unbounded
state size for the window operators.

I’m trying to submit the fix PR before tomorrow. It will be reasonable to
aim this fix for 1.1.2 too.
+1 to release 1.1.2 soon as they will include these critical fixes.

Regards,
Gordon

On August 24, 2016 at 6:25:45 PM, Ufuk Celebi ([hidden email]) wrote:

It's been ~2 weeks since we released Flink 1.1.1 and I wanted to start
discussing releasing Flink 1.1.2.

There have been 27 commits in the release-1.1 branch since the
release, including at least one critical issue:

[FLINK-4332] [checkpoints] Fix SavepointV1Serializer read() /
readFully() (2 weeks ago) <Stephan Ewen>

This can lead to savepoints being not deserialized correctly. A user
did already run into this and reported it in FLINK-4425. There are
also other minor user reported issues (like FLINK-4454) that have been
fixed.

What do you think about this? We would need a volunteer for release
manager.

– Ufuk

[mxm]

+1 for a 1.1.2 release soon. I think we should have the fixes in by
the beginning of next week. Otherwise, further fixes could also make
it into 1.1.3.



On Wed, Aug 24, 2016 at 12:32 PM, Gyula Fóra <[hidden email]> wrote:

> Hi,
>
> I agree that there has been some critical issues discovered and it would be
> to get the fixes out as soon as possible :)
>
> On my side I would like to add the fixes for:
> FLINK-4441
> FLINK-4471
>
> Both can be critical for applications that use the RocksDB backend.
>
> Gyula
>
> Ufuk Celebi <[hidden email]> ezt írta (időpont: 2016. aug. 24., Sze, 12:25):
>
>> It's been ~2 weeks since we released Flink 1.1.1 and I wanted to start
>> discussing releasing Flink 1.1.2.
>>
>> There have been 27 commits in the release-1.1 branch since the
>> release, including at least one critical issue:
>>
>> [FLINK-4332] [checkpoints] Fix SavepointV1Serializer read() /
>> readFully() (2 weeks ago) <Stephan Ewen>
>>
>> This can lead to savepoints being not deserialized correctly. A user
>> did already run into this and reported it in FLINK-4425. There are
>> also other minor user reported issues (like FLINK-4454) that have been
>> fixed.
>>
>> What do you think about this? We would need a volunteer for release
>> manager.
>>
>> – Ufuk
>>

[Fabian Hueske-2]

+1 for a 1.1.2 release.

I'd like to have the Joda time exclusion removed from the Quickstart POM to
include the dependency in the fat jar.
Otherwise jobs with that dependency (such as the Flink training examples)
fail with ClassNotFound.

Robert fix that on the side in https://github.com/apache/flink/pull/2153.
So it would be good to have the PR in 1.1.2 or at least the relevant change
be separately merged.

Cheers, Fabian

2016-08-24 12:45 GMT+02:00 Maximilian Michels <[hidden email]>:

> +1 for a 1.1.2 release soon. I think we should have the fixes in by
> the beginning of next week. Otherwise, further fixes could also make
> it into 1.1.3.
>
>
>
> On Wed, Aug 24, 2016 at 12:32 PM, Gyula Fóra <[hidden email]> wrote:
> > Hi,
> >
> > I agree that there has been some critical issues discovered and it would
> be
> > to get the fixes out as soon as possible :)
> >
> > On my side I would like to add the fixes for:
> > FLINK-4441
> > FLINK-4471
> >
> > Both can be critical for applications that use the RocksDB backend.
> >
> > Gyula
> >
> > Ufuk Celebi <[hidden email]> ezt írta (időpont: 2016. aug. 24., Sze,
> 12:25):
> >
> >> It's been ~2 weeks since we released Flink 1.1.1 and I wanted to start
> >> discussing releasing Flink 1.1.2.
> >>
> >> There have been 27 commits in the release-1.1 branch since the
> >> release, including at least one critical issue:
> >>
> >> [FLINK-4332] [checkpoints] Fix SavepointV1Serializer read() /
> >> readFully() (2 weeks ago) <Stephan Ewen>
> >>
> >> This can lead to savepoints being not deserialized correctly. A user
> >> did already run into this and reported it in FLINK-4425. There are
> >> also other minor user reported issues (like FLINK-4454) that have been
> >> fixed.
> >>
> >> What do you think about this? We would need a volunteer for release
> >> manager.
> >>
> >> – Ufuk
> >>
>

[Stephan Ewen]

+1 for 1.1.2

Looks like everything is in the release-1.1 branch already except the
Kinesis and Quickstart fix.
For the Kinesis issue Tzu-Liu Tai seems onto it already.
The quickstart is trivial fix.

Let's aim for patch-freeze next week Monday evening?


On Fri, Aug 26, 2016 at 3:11 PM, Fabian Hueske <[hidden email]> wrote:

> +1 for a 1.1.2 release.
>
> I'd like to have the Joda time exclusion removed from the Quickstart POM to
> include the dependency in the fat jar.
> Otherwise jobs with that dependency (such as the Flink training examples)
> fail with ClassNotFound.
>
> Robert fix that on the side in https://github.com/apache/flink/pull/2153.
> So it would be good to have the PR in 1.1.2 or at least the relevant change
> be separately merged.
>
> Cheers, Fabian
>
> 2016-08-24 12:45 GMT+02:00 Maximilian Michels <[hidden email]>:
>
> > +1 for a 1.1.2 release soon. I think we should have the fixes in by
> > the beginning of next week. Otherwise, further fixes could also make
> > it into 1.1.3.
> >
> >
> >
> > On Wed, Aug 24, 2016 at 12:32 PM, Gyula Fóra <[hidden email]> wrote:
> > > Hi,
> > >
> > > I agree that there has been some critical issues discovered and it
> would
> > be
> > > to get the fixes out as soon as possible :)
> > >
> > > On my side I would like to add the fixes for:
> > > FLINK-4441
> > > FLINK-4471
> > >
> > > Both can be critical for applications that use the RocksDB backend.
> > >
> > > Gyula
> > >
> > > Ufuk Celebi <[hidden email]> ezt írta (időpont: 2016. aug. 24., Sze,
> > 12:25):
> > >
> > >> It's been ~2 weeks since we released Flink 1.1.1 and I wanted to start
> > >> discussing releasing Flink 1.1.2.
> > >>
> > >> There have been 27 commits in the release-1.1 branch since the
> > >> release, including at least one critical issue:
> > >>
> > >> [FLINK-4332] [checkpoints] Fix SavepointV1Serializer read() /
> > >> readFully() (2 weeks ago) <Stephan Ewen>
> > >>
> > >> This can lead to savepoints being not deserialized correctly. A user
> > >> did already run into this and reported it in FLINK-4425. There are
> > >> also other minor user reported issues (like FLINK-4454) that have been
> > >> fixed.
> > >>
> > >> What do you think about this? We would need a volunteer for release
> > >> manager.
> > >>
> > >> – Ufuk
> > >>
> >
>

[Tzu-Li (Gordon) Tai]

Next week Monday evening should be fine to get the Kinesis issue fix in.

On Sat, Aug 27, 2016 at 12:13 AM, Stephan Ewen <[hidden email]> wrote:

> +1 for 1.1.2
>
> Looks like everything is in the release-1.1 branch already except the
> Kinesis and Quickstart fix.
> For the Kinesis issue Tzu-Liu Tai seems onto it already.
> The quickstart is trivial fix.
>
> Let's aim for patch-freeze next week Monday evening?
>
>
> On Fri, Aug 26, 2016 at 3:11 PM, Fabian Hueske <[hidden email]> wrote:
>
> > +1 for a 1.1.2 release.
> >
> > I'd like to have the Joda time exclusion removed from the Quickstart POM
> to
> > include the dependency in the fat jar.
> > Otherwise jobs with that dependency (such as the Flink training examples)
> > fail with ClassNotFound.
> >
> > Robert fix that on the side in https://github.com/apache/flink/pull/2153
> .
> > So it would be good to have the PR in 1.1.2 or at least the relevant
> change
> > be separately merged.
> >
> > Cheers, Fabian
> >
> > 2016-08-24 12:45 GMT+02:00 Maximilian Michels <[hidden email]>:
> >
> > > +1 for a 1.1.2 release soon. I think we should have the fixes in by
> > > the beginning of next week. Otherwise, further fixes could also make
> > > it into 1.1.3.
> > >
> > >
> > >
> > > On Wed, Aug 24, 2016 at 12:32 PM, Gyula Fóra <[hidden email]>
> wrote:
> > > > Hi,
> > > >
> > > > I agree that there has been some critical issues discovered and it
> > would
> > > be
> > > > to get the fixes out as soon as possible :)
> > > >
> > > > On my side I would like to add the fixes for:
> > > > FLINK-4441
> > > > FLINK-4471
> > > >
> > > > Both can be critical for applications that use the RocksDB backend.
> > > >
> > > > Gyula
> > > >
> > > > Ufuk Celebi <[hidden email]> ezt írta (időpont: 2016. aug. 24., Sze,
> > > 12:25):
> > > >
> > > >> It's been ~2 weeks since we released Flink 1.1.1 and I wanted to
> start
> > > >> discussing releasing Flink 1.1.2.
> > > >>
> > > >> There have been 27 commits in the release-1.1 branch since the
> > > >> release, including at least one critical issue:
> > > >>
> > > >> [FLINK-4332] [checkpoints] Fix SavepointV1Serializer read() /
> > > >> readFully() (2 weeks ago) <Stephan Ewen>
> > > >>
> > > >> This can lead to savepoints being not deserialized correctly. A user
> > > >> did already run into this and reported it in FLINK-4425. There are
> > > >> also other minor user reported issues (like FLINK-4454) that have
> been
> > > >> fixed.
> > > >>
> > > >> What do you think about this? We would need a volunteer for release
> > > >> manager.
> > > >>
> > > >> – Ufuk
> > > >>
> > >
> >
>

[Robert Metzger]

Gordon fixed the Kinesis consumer already over the weekend. I just merged
the change.

I'll push a hotfix for the jodatime+quickstart issue to both branches.

On Fri, Aug 26, 2016 at 6:35 PM, Tzu-Li (Gordon) Tai <[hidden email]>
wrote:

> Next week Monday evening should be fine to get the Kinesis issue fix in.
>
> On Sat, Aug 27, 2016 at 12:13 AM, Stephan Ewen <[hidden email]> wrote:
>
> > +1 for 1.1.2
> >
> > Looks like everything is in the release-1.1 branch already except the
> > Kinesis and Quickstart fix.
> > For the Kinesis issue Tzu-Liu Tai seems onto it already.
> > The quickstart is trivial fix.
> >
> > Let's aim for patch-freeze next week Monday evening?
> >
> >
> > On Fri, Aug 26, 2016 at 3:11 PM, Fabian Hueske <[hidden email]>
> wrote:
> >
> > > +1 for a 1.1.2 release.
> > >
> > > I'd like to have the Joda time exclusion removed from the Quickstart
> POM
> > to
> > > include the dependency in the fat jar.
> > > Otherwise jobs with that dependency (such as the Flink training
> examples)
> > > fail with ClassNotFound.
> > >
> > > Robert fix that on the side in https://github.com/apache/
> flink/pull/2153
> > .
> > > So it would be good to have the PR in 1.1.2 or at least the relevant
> > change
> > > be separately merged.
> > >
> > > Cheers, Fabian
> > >
> > > 2016-08-24 12:45 GMT+02:00 Maximilian Michels <[hidden email]>:
> > >
> > > > +1 for a 1.1.2 release soon. I think we should have the fixes in by
> > > > the beginning of next week. Otherwise, further fixes could also make
> > > > it into 1.1.3.
> > > >
> > > >
> > > >
> > > > On Wed, Aug 24, 2016 at 12:32 PM, Gyula Fóra <[hidden email]>
> > wrote:
> > > > > Hi,
> > > > >
> > > > > I agree that there has been some critical issues discovered and it
> > > would
> > > > be
> > > > > to get the fixes out as soon as possible :)
> > > > >
> > > > > On my side I would like to add the fixes for:
> > > > > FLINK-4441
> > > > > FLINK-4471
> > > > >
> > > > > Both can be critical for applications that use the RocksDB backend.
> > > > >
> > > > > Gyula
> > > > >
> > > > > Ufuk Celebi <[hidden email]> ezt írta (időpont: 2016. aug. 24.,
> Sze,
> > > > 12:25):
> > > > >
> > > > >> It's been ~2 weeks since we released Flink 1.1.1 and I wanted to
> > start
> > > > >> discussing releasing Flink 1.1.2.
> > > > >>
> > > > >> There have been 27 commits in the release-1.1 branch since the
> > > > >> release, including at least one critical issue:
> > > > >>
> > > > >> [FLINK-4332] [checkpoints] Fix SavepointV1Serializer read() /
> > > > >> readFully() (2 weeks ago) <Stephan Ewen>
> > > > >>
> > > > >> This can lead to savepoints being not deserialized correctly. A
> user
> > > > >> did already run into this and reported it in FLINK-4425. There are
> > > > >> also other minor user reported issues (like FLINK-4454) that have
> > been
> > > > >> fixed.
> > > > >>
> > > > >> What do you think about this? We would need a volunteer for
> release
> > > > >> manager.
> > > > >>
> > > > >> – Ufuk
> > > > >>
> > > >
> > >
> >
>

[Robert Metzger]

I'll create a release candidate now.

On Mon, Aug 29, 2016 at 11:51 AM, Robert Metzger <[hidden email]>
wrote:

> Gordon fixed the Kinesis consumer already over the weekend. I just merged
> the change.
>
> I'll push a hotfix for the jodatime+quickstart issue to both branches.
>
> On Fri, Aug 26, 2016 at 6:35 PM, Tzu-Li (Gordon) Tai <[hidden email]>
> wrote:
>
>> Next week Monday evening should be fine to get the Kinesis issue fix in.
>>
>> On Sat, Aug 27, 2016 at 12:13 AM, Stephan Ewen <[hidden email]> wrote:
>>
>> > +1 for 1.1.2
>> >
>> > Looks like everything is in the release-1.1 branch already except the
>> > Kinesis and Quickstart fix.
>> > For the Kinesis issue Tzu-Liu Tai seems onto it already.
>> > The quickstart is trivial fix.
>> >
>> > Let's aim for patch-freeze next week Monday evening?
>> >
>> >
>> > On Fri, Aug 26, 2016 at 3:11 PM, Fabian Hueske <[hidden email]>
>> wrote:
>> >
>> > > +1 for a 1.1.2 release.
>> > >
>> > > I'd like to have the Joda time exclusion removed from the Quickstart
>> POM
>> > to
>> > > include the dependency in the fat jar.
>> > > Otherwise jobs with that dependency (such as the Flink training
>> examples)
>> > > fail with ClassNotFound.
>> > >
>> > > Robert fix that on the side in https://github.com/apache/flin
>> k/pull/2153
>> > .
>> > > So it would be good to have the PR in 1.1.2 or at least the relevant
>> > change
>> > > be separately merged.
>> > >
>> > > Cheers, Fabian
>> > >
>> > > 2016-08-24 12:45 GMT+02:00 Maximilian Michels <[hidden email]>:
>> > >
>> > > > +1 for a 1.1.2 release soon. I think we should have the fixes in by
>> > > > the beginning of next week. Otherwise, further fixes could also make
>> > > > it into 1.1.3.
>> > > >
>> > > >
>> > > >
>> > > > On Wed, Aug 24, 2016 at 12:32 PM, Gyula Fóra <[hidden email]>
>> > wrote:
>> > > > > Hi,
>> > > > >
>> > > > > I agree that there has been some critical issues discovered and it
>> > > would
>> > > > be
>> > > > > to get the fixes out as soon as possible :)
>> > > > >
>> > > > > On my side I would like to add the fixes for:
>> > > > > FLINK-4441
>> > > > > FLINK-4471
>> > > > >
>> > > > > Both can be critical for applications that use the RocksDB
>> backend.
>> > > > >
>> > > > > Gyula
>> > > > >
>> > > > > Ufuk Celebi <[hidden email]> ezt írta (időpont: 2016. aug. 24.,
>> Sze,
>> > > > 12:25):
>> > > > >
>> > > > >> It's been ~2 weeks since we released Flink 1.1.1 and I wanted to
>> > start
>> > > > >> discussing releasing Flink 1.1.2.
>> > > > >>
>> > > > >> There have been 27 commits in the release-1.1 branch since the
>> > > > >> release, including at least one critical issue:
>> > > > >>
>> > > > >> [FLINK-4332] [checkpoints] Fix SavepointV1Serializer read() /
>> > > > >> readFully() (2 weeks ago) <Stephan Ewen>
>> > > > >>
>> > > > >> This can lead to savepoints being not deserialized correctly. A
>> user
>> > > > >> did already run into this and reported it in FLINK-4425. There
>> are
>> > > > >> also other minor user reported issues (like FLINK-4454) that have
>> > been
>> > > > >> fixed.
>> > > > >>
>> > > > >> What do you think about this? We would need a volunteer for
>> release
>> > > > >> manager.
>> > > > >>
>> > > > >> – Ufuk
>> > > > >>
>> > > >
>> > >
>> >
>>
>
>