[DISCUSS] Release Flink 1.4.2

[Tzu-Li (Gordon) Tai]

Hi all,

Unfortunately, we've discovered a bug in 1.4.1, which suggests that we
should almost immediately release another bugfix release:
https://issues.apache.org/jira/browse/FLINK-8741.

Since this issue was introduced only in 1.4.1, it might make sense to
release 1.4.2 with only the fix for FLINK-8741 included. What do you think?

Best,
Gordon

<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
不含病毒。www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

[Till Rohrmann]

If the Kafka connectors are unusable with 1.4.1, then I would be in favor
of releasing 1.4.2 asap.

I'm wondering why the end-to-end Kafka tests did not catch this problem.
Maybe we could adapt them such that they guard against it in the future.

Cheers,
Till

On Thu, Feb 22, 2018 at 9:46 AM, Tzu-Li (Gordon) Tai <[hidden email]>
wrote:

> Hi all,
>
> Unfortunately, we've discovered a bug in 1.4.1, which suggests that we
> should almost immediately release another bugfix release:
> https://issues.apache.org/jira/browse/FLINK-8741.
>
> Since this issue was introduced only in 1.4.1, it might make sense to
> release 1.4.2 with only the fix for FLINK-8741 included. What do you think?
>
> Best,
> Gordon
>
> <https://www.avast.com/sig-email?utm_medium=email&utm_
> source=link&utm_campaign=sig-email&utm_content=webmail>
> 不含病毒。www.avast.com
> <https://www.avast.com/sig-email?utm_medium=email&utm_
> source=link&utm_campaign=sig-email&utm_content=webmail>
> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>

[Aljoscha Krettek-2]

They reason they didn't catch this is that the bug only occurs if users use a custom timestamp/watermark assigner. But yes, we should be able to extend the end-to-end tests to catch this.

> On 22. Feb 2018, at 11:05, Till Rohrmann <[hidden email]> wrote:
>
> If the Kafka connectors are unusable with 1.4.1, then I would be in favor
> of releasing 1.4.2 asap.
>
> I'm wondering why the end-to-end Kafka tests did not catch this problem.
> Maybe we could adapt them such that they guard against it in the future.
>
> Cheers,
> Till
>
> On Thu, Feb 22, 2018 at 9:46 AM, Tzu-Li (Gordon) Tai <[hidden email]>
> wrote:
>
>> Hi all,
>>
>> Unfortunately, we've discovered a bug in 1.4.1, which suggests that we
>> should almost immediately release another bugfix release:
>> https://issues.apache.org/jira/browse/FLINK-8741.
>>
>> Since this issue was introduced only in 1.4.1, it might make sense to
>> release 1.4.2 with only the fix for FLINK-8741 included. What do you think?
>>
>> Best,
>> Gordon
>>
>> <https://www.avast.com/sig-email?utm_medium=email&utm_
>> source=link&utm_campaign=sig-email&utm_content=webmail>
>> 不含病毒。www.avast.com
>> <https://www.avast.com/sig-email?utm_medium=email&utm_
>> source=link&utm_campaign=sig-email&utm_content=webmail>
>> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>>

[Timo Walther-2]

I also almost have a fix ready for FLINK-8451. I think it should also go
into 1.4.2.

Regards,
Timo


Am 2/22/18 um 11:29 AM schrieb Aljoscha Krettek:

> They reason they didn't catch this is that the bug only occurs if users use a custom timestamp/watermark assigner. But yes, we should be able to extend the end-to-end tests to catch this.
>
>> On 22. Feb 2018, at 11:05, Till Rohrmann <[hidden email]> wrote:
>>
>> If the Kafka connectors are unusable with 1.4.1, then I would be in favor
>> of releasing 1.4.2 asap.
>>
>> I'm wondering why the end-to-end Kafka tests did not catch this problem.
>> Maybe we could adapt them such that they guard against it in the future.
>>
>> Cheers,
>> Till
>>
>> On Thu, Feb 22, 2018 at 9:46 AM, Tzu-Li (Gordon) Tai <[hidden email]>
>> wrote:
>>
>>> Hi all,
>>>
>>> Unfortunately, we've discovered a bug in 1.4.1, which suggests that we
>>> should almost immediately release another bugfix release:
>>> https://issues.apache.org/jira/browse/FLINK-8741.
>>>
>>> Since this issue was introduced only in 1.4.1, it might make sense to
>>> release 1.4.2 with only the fix for FLINK-8741 included. What do you think?
>>>
>>> Best,
>>> Gordon
>>>
>>> <https://www.avast.com/sig-email?utm_medium=email&utm_
>>> source=link&utm_campaign=sig-email&utm_content=webmail>
>>> 不含病毒。www.avast.com
>>> <https://www.avast.com/sig-email?utm_medium=email&utm_
>>> source=link&utm_campaign=sig-email&utm_content=webmail>
>>> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>>>

[Stephan Ewen]

How about releasing 1.4.2 now, meaning immediately. This can be very
lightweight.

FLINK-8451 looks like it should have more thorough testing and should go
into 1.4.3.
I think there is no harm in more frequent bugfix releases.


On Fri, Feb 23, 2018 at 9:56 AM, Timo Walther <[hidden email]> wrote:

> I also almost have a fix ready for FLINK-8451. I think it should also go
> into 1.4.2.
>
> Regards,
> Timo
>
>
> Am 2/22/18 um 11:29 AM schrieb Aljoscha Krettek:
>
> They reason they didn't catch this is that the bug only occurs if users
>> use a custom timestamp/watermark assigner. But yes, we should be able to
>> extend the end-to-end tests to catch this.
>>
>> On 22. Feb 2018, at 11:05, Till Rohrmann <[hidden email]> wrote:
>>>
>>> If the Kafka connectors are unusable with 1.4.1, then I would be in favor
>>> of releasing 1.4.2 asap.
>>>
>>> I'm wondering why the end-to-end Kafka tests did not catch this problem.
>>> Maybe we could adapt them such that they guard against it in the future.
>>>
>>> Cheers,
>>> Till
>>>
>>> On Thu, Feb 22, 2018 at 9:46 AM, Tzu-Li (Gordon) Tai <
>>> [hidden email]>
>>> wrote:
>>>
>>> Hi all,
>>>>
>>>> Unfortunately, we've discovered a bug in 1.4.1, which suggests that we
>>>> should almost immediately release another bugfix release:
>>>> https://issues.apache.org/jira/browse/FLINK-8741.
>>>>
>>>> Since this issue was introduced only in 1.4.1, it might make sense to
>>>> release 1.4.2 with only the fix for FLINK-8741 included. What do you
>>>> think?
>>>>
>>>> Best,
>>>> Gordon
>>>>
>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_
>>>> source=link&utm_campaign=sig-email&utm_content=webmail>
>>>> 不含病毒。www.avast.com
>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_
>>>> source=link&utm_campaign=sig-email&utm_content=webmail>
>>>> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>>>>
>>>>
>

[Tzu-Li (Gordon) Tai]

Since we’re still a bit undecided on FLINK-8451, I think it would be best to release 1.4.2 with FLINK-8741 now.
Otherwise, Kafka connectors using custom watermark assigners are basically unusable right now.

I’ll start the build for RC1 for 1.4.2, and will start the vote by the end of the day.
If you object and think we should still try to include FLINK-8451, please let me know.

Cheers,
Gordon

On 23 February 2018 at 8:27:38 PM, Stephan Ewen ([hidden email]) wrote:

How about releasing 1.4.2 now, meaning immediately. This can be very  
lightweight.  

FLINK-8451 looks like it should have more thorough testing and should go  
into 1.4.3.  
I think there is no harm in more frequent bugfix releases.  


On Fri, Feb 23, 2018 at 9:56 AM, Timo Walther <[hidden email]> wrote:  

> I also almost have a fix ready for FLINK-8451. I think it should also go  
> into 1.4.2.  
>  
> Regards,  
> Timo  
>  
>  
> Am 2/22/18 um 11:29 AM schrieb Aljoscha Krettek:  
>  
> They reason they didn't catch this is that the bug only occurs if users  
>> use a custom timestamp/watermark assigner. But yes, we should be able to  
>> extend the end-to-end tests to catch this.  
>>  
>> On 22. Feb 2018, at 11:05, Till Rohrmann <[hidden email]> wrote:  
>>>  
>>> If the Kafka connectors are unusable with 1.4.1, then I would be in favor  
>>> of releasing 1.4.2 asap.  
>>>  
>>> I'm wondering why the end-to-end Kafka tests did not catch this problem.  
>>> Maybe we could adapt them such that they guard against it in the future.  
>>>  
>>> Cheers,  
>>> Till  
>>>  
>>> On Thu, Feb 22, 2018 at 9:46 AM, Tzu-Li (Gordon) Tai <  
>>> [hidden email]>  
>>> wrote:  
>>>  
>>> Hi all,  
>>>>  
>>>> Unfortunately, we've discovered a bug in 1.4.1, which suggests that we  
>>>> should almost immediately release another bugfix release:  
>>>> https://issues.apache.org/jira/browse/FLINK-8741.  
>>>>  
>>>> Since this issue was introduced only in 1.4.1, it might make sense to  
>>>> release 1.4.2 with only the fix for FLINK-8741 included. What do you  
>>>> think?  
>>>>  
>>>> Best,  
>>>> Gordon  
>>>>  
>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_ 
>>>> source=link&utm_campaign=sig-email&utm_content=webmail>  
>>>> 不含病毒。www.avast.com  
>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_ 
>>>> source=link&utm_campaign=sig-email&utm_content=webmail>  
>>>> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>  
>>>>  
>>>>  
>  

[Ufuk Celebi-2]

Since users already reported this on the ML, I'm big +1 to release immediately.

On Tue, Feb 27, 2018 at 7:45 AM, Tzu-Li (Gordon) Tai
<[hidden email]> wrote:

> Since we’re still a bit undecided on FLINK-8451, I think it would be best to release 1.4.2 with FLINK-8741 now.
> Otherwise, Kafka connectors using custom watermark assigners are basically unusable right now.
>
> I’ll start the build for RC1 for 1.4.2, and will start the vote by the end of the day.
> If you object and think we should still try to include FLINK-8451, please let me know.
>
> Cheers,
> Gordon
>
> On 23 February 2018 at 8:27:38 PM, Stephan Ewen ([hidden email]) wrote:
>
> How about releasing 1.4.2 now, meaning immediately. This can be very
> lightweight.
>
> FLINK-8451 looks like it should have more thorough testing and should go
> into 1.4.3.
> I think there is no harm in more frequent bugfix releases.
>
>
> On Fri, Feb 23, 2018 at 9:56 AM, Timo Walther <[hidden email]> wrote:
>
>> I also almost have a fix ready for FLINK-8451. I think it should also go
>> into 1.4.2.
>>
>> Regards,
>> Timo
>>
>>
>> Am 2/22/18 um 11:29 AM schrieb Aljoscha Krettek:
>>
>> They reason they didn't catch this is that the bug only occurs if users
>>> use a custom timestamp/watermark assigner. But yes, we should be able to
>>> extend the end-to-end tests to catch this.
>>>
>>> On 22. Feb 2018, at 11:05, Till Rohrmann <[hidden email]> wrote:
>>>>
>>>> If the Kafka connectors are unusable with 1.4.1, then I would be in favor
>>>> of releasing 1.4.2 asap.
>>>>
>>>> I'm wondering why the end-to-end Kafka tests did not catch this problem.
>>>> Maybe we could adapt them such that they guard against it in the future.
>>>>
>>>> Cheers,
>>>> Till
>>>>
>>>> On Thu, Feb 22, 2018 at 9:46 AM, Tzu-Li (Gordon) Tai <
>>>> [hidden email]>
>>>> wrote:
>>>>
>>>> Hi all,
>>>>>
>>>>> Unfortunately, we've discovered a bug in 1.4.1, which suggests that we
>>>>> should almost immediately release another bugfix release:
>>>>> https://issues.apache.org/jira/browse/FLINK-8741.
>>>>>
>>>>> Since this issue was introduced only in 1.4.1, it might make sense to
>>>>> release 1.4.2 with only the fix for FLINK-8741 included. What do you
>>>>> think?
>>>>>
>>>>> Best,
>>>>> Gordon
>>>>>
>>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_
>>>>> source=link&utm_campaign=sig-email&utm_content=webmail>
>>>>> 不含病毒。www.avast.com
>>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_
>>>>> source=link&utm_campaign=sig-email&utm_content=webmail>
>>>>> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>>>>>
>>>>>
>>

[Stephan Ewen]

+1 to an immediate 1.4.2 release


On Tue, Feb 27, 2018 at 9:43 AM, Ufuk Celebi <[hidden email]> wrote:

> Since users already reported this on the ML, I'm big +1 to release
> immediately.
>
> On Tue, Feb 27, 2018 at 7:45 AM, Tzu-Li (Gordon) Tai
> <[hidden email]> wrote:
> > Since we’re still a bit undecided on FLINK-8451, I think it would be
> best to release 1.4.2 with FLINK-8741 now.
> > Otherwise, Kafka connectors using custom watermark assigners are
> basically unusable right now.
> >
> > I’ll start the build for RC1 for 1.4.2, and will start the vote by the
> end of the day.
> > If you object and think we should still try to include FLINK-8451,
> please let me know.
> >
> > Cheers,
> > Gordon
> >
> > On 23 February 2018 at 8:27:38 PM, Stephan Ewen ([hidden email])
> wrote:
> >
> > How about releasing 1.4.2 now, meaning immediately. This can be very
> > lightweight.
> >
> > FLINK-8451 looks like it should have more thorough testing and should go
> > into 1.4.3.
> > I think there is no harm in more frequent bugfix releases.
> >
> >
> > On Fri, Feb 23, 2018 at 9:56 AM, Timo Walther <[hidden email]>
> wrote:
> >
> >> I also almost have a fix ready for FLINK-8451. I think it should also go
> >> into 1.4.2.
> >>
> >> Regards,
> >> Timo
> >>
> >>
> >> Am 2/22/18 um 11:29 AM schrieb Aljoscha Krettek:
> >>
> >> They reason they didn't catch this is that the bug only occurs if users
> >>> use a custom timestamp/watermark assigner. But yes, we should be able
> to
> >>> extend the end-to-end tests to catch this.
> >>>
> >>> On 22. Feb 2018, at 11:05, Till Rohrmann <[hidden email]> wrote:
> >>>>
> >>>> If the Kafka connectors are unusable with 1.4.1, then I would be in
> favor
> >>>> of releasing 1.4.2 asap.
> >>>>
> >>>> I'm wondering why the end-to-end Kafka tests did not catch this
> problem.
> >>>> Maybe we could adapt them such that they guard against it in the
> future.
> >>>>
> >>>> Cheers,
> >>>> Till
> >>>>
> >>>> On Thu, Feb 22, 2018 at 9:46 AM, Tzu-Li (Gordon) Tai <
> >>>> [hidden email]>
> >>>> wrote:
> >>>>
> >>>> Hi all,
> >>>>>
> >>>>> Unfortunately, we've discovered a bug in 1.4.1, which suggests that
> we
> >>>>> should almost immediately release another bugfix release:
> >>>>> https://issues.apache.org/jira/browse/FLINK-8741.
> >>>>>
> >>>>> Since this issue was introduced only in 1.4.1, it might make sense to
> >>>>> release 1.4.2 with only the fix for FLINK-8741 included. What do you
> >>>>> think?
> >>>>>
> >>>>> Best,
> >>>>> Gordon
> >>>>>
> >>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_
> >>>>> source=link&utm_campaign=sig-email&utm_content=webmail>
> >>>>> 不含病毒。www.avast.com
> >>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_
> >>>>> source=link&utm_campaign=sig-email&utm_content=webmail>
> >>>>> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
> >>>>>
> >>>>>
> >>
>