[DISCUSS] Release 1.0.1 Bugfix release

[Aljoscha Krettek-2]

Hi,
I’m aware of one critical fix and one somewhat critical fix since 1.0.0. One concerns data loss in the RollingSink, the other is a bug in a window trigger. I would like to release a bugfix release since some people are restricted to using released versions and are also depending on the RollingSink. For them, now having a bugfix release would be a blocker.

What do you think? Are there any other critical bugs/fixes that we are aware of?

Best,
Aljoscha

[Ufuk Celebi-2]

Big +1, let's get this rolling... ;)

On Wed, Mar 23, 2016 at 11:14 AM, Aljoscha Krettek <[hidden email]> wrote:
> Hi,
> I’m aware of one critical fix and one somewhat critical fix since 1.0.0. One concerns data loss in the RollingSink, the other is a bug in a window trigger. I would like to release a bugfix release since some people are restricted to using released versions and are also depending on the RollingSink. For them, now having a bugfix release would be a blocker.
>
> What do you think? Are there any other critical bugs/fixes that we are aware of?
>
> Best,
> Aljoscha

[Stephan Ewen]

Yes, there is also the Rich Scala Window Functions, and the tests that used
to address wrong JAR directories.

On Wed, Mar 23, 2016 at 11:15 AM, Ufuk Celebi <[hidden email]> wrote:

> Big +1, let's get this rolling... ;)
>
> On Wed, Mar 23, 2016 at 11:14 AM, Aljoscha Krettek <[hidden email]>
> wrote:
> > Hi,
> > I’m aware of one critical fix and one somewhat critical fix since 1.0.0.
> One concerns data loss in the RollingSink, the other is a bug in a window
> trigger. I would like to release a bugfix release since some people are
> restricted to using released versions and are also depending on the
> RollingSink. For them, now having a bugfix release would be a blocker.
> >
> > What do you think? Are there any other critical bugs/fixes that we are
> aware of?
> >
> > Best,
> > Aljoscha
>

[Till Rohrmann]

+1

On Wed, Mar 23, 2016 at 11:24 AM, Stephan Ewen <[hidden email]> wrote:

> Yes, there is also the Rich Scala Window Functions, and the tests that used
> to address wrong JAR directories.
>
> On Wed, Mar 23, 2016 at 11:15 AM, Ufuk Celebi <[hidden email]> wrote:
>
> > Big +1, let's get this rolling... ;)
> >
> > On Wed, Mar 23, 2016 at 11:14 AM, Aljoscha Krettek <[hidden email]>
> > wrote:
> > > Hi,
> > > I’m aware of one critical fix and one somewhat critical fix since
> 1.0.0.
> > One concerns data loss in the RollingSink, the other is a bug in a window
> > trigger. I would like to release a bugfix release since some people are
> > restricted to using released versions and are also depending on the
> > RollingSink. For them, now having a bugfix release would be a blocker.
> > >
> > > What do you think? Are there any other critical bugs/fixes that we are
> > aware of?
> > >
> > > Best,
> > > Aljoscha
> >
>

[mxm]

+1

On Wed, Mar 23, 2016 at 12:19 PM, Till Rohrmann <[hidden email]> wrote:

> +1
>
> On Wed, Mar 23, 2016 at 11:24 AM, Stephan Ewen <[hidden email]> wrote:
>
>> Yes, there is also the Rich Scala Window Functions, and the tests that used
>> to address wrong JAR directories.
>>
>> On Wed, Mar 23, 2016 at 11:15 AM, Ufuk Celebi <[hidden email]> wrote:
>>
>> > Big +1, let's get this rolling... ;)
>> >
>> > On Wed, Mar 23, 2016 at 11:14 AM, Aljoscha Krettek <[hidden email]>
>> > wrote:
>> > > Hi,
>> > > I’m aware of one critical fix and one somewhat critical fix since
>> 1.0.0.
>> > One concerns data loss in the RollingSink, the other is a bug in a window
>> > trigger. I would like to release a bugfix release since some people are
>> > restricted to using released versions and are also depending on the
>> > RollingSink. For them, now having a bugfix release would be a blocker.
>> > >
>> > > What do you think? Are there any other critical bugs/fixes that we are
>> > aware of?
>> > >
>> > > Best,
>> > > Aljoscha
>> >
>>

[Robert Metzger]

+1

I just went through the master and release-1.0 branch, and most important
fixes are already in the release-1.0 branch.
I would also move this commit into the release branch:
"[FLINK-3636] Add ThrottledIterator to WindowJoin jar"
https://github.com/apache/flink/commit/f09d68a05efb4afeb7b8498d35201e8324d6c096

From the pull requests I would include:
"[FLINK-3651] Fix faulty RollingSink Restore"
https://github.com/apache/flink/pull/1830

Anything else?

I would like to manage the release, but I'm on vacation next week, so I
think somebody else should do it ;)


On Wed, Mar 23, 2016 at 2:18 PM, Maximilian Michels <[hidden email]> wrote:

> +1
>
> On Wed, Mar 23, 2016 at 12:19 PM, Till Rohrmann <[hidden email]>
> wrote:
> > +1
> >
> > On Wed, Mar 23, 2016 at 11:24 AM, Stephan Ewen <[hidden email]> wrote:
> >
> >> Yes, there is also the Rich Scala Window Functions, and the tests that
> used
> >> to address wrong JAR directories.
> >>
> >> On Wed, Mar 23, 2016 at 11:15 AM, Ufuk Celebi <[hidden email]> wrote:
> >>
> >> > Big +1, let's get this rolling... ;)
> >> >
> >> > On Wed, Mar 23, 2016 at 11:14 AM, Aljoscha Krettek <
> [hidden email]>
> >> > wrote:
> >> > > Hi,
> >> > > I’m aware of one critical fix and one somewhat critical fix since
> >> 1.0.0.
> >> > One concerns data loss in the RollingSink, the other is a bug in a
> window
> >> > trigger. I would like to release a bugfix release since some people
> are
> >> > restricted to using released versions and are also depending on the
> >> > RollingSink. For them, now having a bugfix release would be a blocker.
> >> > >
> >> > > What do you think? Are there any other critical bugs/fixes that we
> are
> >> > aware of?
> >> > >
> >> > > Best,
> >> > > Aljoscha
> >> >
> >>
>

[Chiwan Park-2]

+1

Regards,
Chiwan Park

> On Mar 23, 2016, at 11:24 PM, Robert Metzger <[hidden email]> wrote:
>
> +1
>
> I just went through the master and release-1.0 branch, and most important
> fixes are already in the release-1.0 branch.
> I would also move this commit into the release branch:
> "[FLINK-3636] Add ThrottledIterator to WindowJoin jar"
> https://github.com/apache/flink/commit/f09d68a05efb4afeb7b8498d35201e8324d6c096
>
> From the pull requests I would include:
> "[FLINK-3651] Fix faulty RollingSink Restore"
> https://github.com/apache/flink/pull/1830
>
> Anything else?
>
> I would like to manage the release, but I'm on vacation next week, so I
> think somebody else should do it ;)
>
>
> On Wed, Mar 23, 2016 at 2:18 PM, Maximilian Michels <[hidden email]> wrote:
>
>> +1
>>
>> On Wed, Mar 23, 2016 at 12:19 PM, Till Rohrmann <[hidden email]>
>> wrote:
>>> +1
>>>
>>> On Wed, Mar 23, 2016 at 11:24 AM, Stephan Ewen <[hidden email]> wrote:
>>>
>>>> Yes, there is also the Rich Scala Window Functions, and the tests that
>> used
>>>> to address wrong JAR directories.
>>>>
>>>> On Wed, Mar 23, 2016 at 11:15 AM, Ufuk Celebi <[hidden email]> wrote:
>>>>
>>>>> Big +1, let's get this rolling... ;)
>>>>>
>>>>> On Wed, Mar 23, 2016 at 11:14 AM, Aljoscha Krettek <
>> [hidden email]>
>>>>> wrote:
>>>>>> Hi,
>>>>>> I’m aware of one critical fix and one somewhat critical fix since
>>>> 1.0.0.
>>>>> One concerns data loss in the RollingSink, the other is a bug in a
>> window
>>>>> trigger. I would like to release a bugfix release since some people
>> are
>>>>> restricted to using released versions and are also depending on the
>>>>> RollingSink. For them, now having a bugfix release would be a blocker.
>>>>>>
>>>>>> What do you think? Are there any other critical bugs/fixes that we
>> are
>>>>> aware of?
>>>>>>
>>>>>> Best,
>>>>>> Aljoscha
>>>>>
>>>>
>>

[Ufuk Celebi-2]

I just merged #1830 and will create a RC after cherry picking
'[FLINK-3636] Add ThrottledIterator to WindowJoin jar' to the
release-1.0 branch.

Thanks for kicking off the discussion Aljoscha!

– Ufuk

On Thu, Mar 24, 2016 at 5:07 AM, Chiwan Park <[hidden email]> wrote:

> +1
>
> Regards,
> Chiwan Park
>
>> On Mar 23, 2016, at 11:24 PM, Robert Metzger <[hidden email]> wrote:
>>
>> +1
>>
>> I just went through the master and release-1.0 branch, and most important
>> fixes are already in the release-1.0 branch.
>> I would also move this commit into the release branch:
>> "[FLINK-3636] Add ThrottledIterator to WindowJoin jar"
>> https://github.com/apache/flink/commit/f09d68a05efb4afeb7b8498d35201e8324d6c096
>>
>> From the pull requests I would include:
>> "[FLINK-3651] Fix faulty RollingSink Restore"
>> https://github.com/apache/flink/pull/1830
>>
>> Anything else?
>>
>> I would like to manage the release, but I'm on vacation next week, so I
>> think somebody else should do it ;)
>>
>>
>> On Wed, Mar 23, 2016 at 2:18 PM, Maximilian Michels <[hidden email]> wrote:
>>
>>> +1
>>>
>>> On Wed, Mar 23, 2016 at 12:19 PM, Till Rohrmann <[hidden email]>
>>> wrote:
>>>> +1
>>>>
>>>> On Wed, Mar 23, 2016 at 11:24 AM, Stephan Ewen <[hidden email]> wrote:
>>>>
>>>>> Yes, there is also the Rich Scala Window Functions, and the tests that
>>> used
>>>>> to address wrong JAR directories.
>>>>>
>>>>> On Wed, Mar 23, 2016 at 11:15 AM, Ufuk Celebi <[hidden email]> wrote:
>>>>>
>>>>>> Big +1, let's get this rolling... ;)
>>>>>>
>>>>>> On Wed, Mar 23, 2016 at 11:14 AM, Aljoscha Krettek <
>>> [hidden email]>
>>>>>> wrote:
>>>>>>> Hi,
>>>>>>> I’m aware of one critical fix and one somewhat critical fix since
>>>>> 1.0.0.
>>>>>> One concerns data loss in the RollingSink, the other is a bug in a
>>> window
>>>>>> trigger. I would like to release a bugfix release since some people
>>> are
>>>>>> restricted to using released versions and are also depending on the
>>>>>> RollingSink. For them, now having a bugfix release would be a blocker.
>>>>>>>
>>>>>>> What do you think? Are there any other critical bugs/fixes that we
>>> are
>>>>>> aware of?
>>>>>>>
>>>>>>> Best,
>>>>>>> Aljoscha
>>>>>>
>>>>>
>>>
>

[Suneel Marthi-2]

what about PR# 1829? We need it real bad for an upcoming release.

On Tue, Mar 29, 2016 at 1:17 PM, Ufuk Celebi <[hidden email]> wrote:

> I just merged #1830 and will create a RC after cherry picking
> '[FLINK-3636] Add ThrottledIterator to WindowJoin jar' to the
> release-1.0 branch.
>
> Thanks for kicking off the discussion Aljoscha!
>
> – Ufuk
>
> On Thu, Mar 24, 2016 at 5:07 AM, Chiwan Park <[hidden email]>
> wrote:
> > +1
> >
> > Regards,
> > Chiwan Park
> >
> >> On Mar 23, 2016, at 11:24 PM, Robert Metzger <[hidden email]>
> wrote:
> >>
> >> +1
> >>
> >> I just went through the master and release-1.0 branch, and most
> important
> >> fixes are already in the release-1.0 branch.
> >> I would also move this commit into the release branch:
> >> "[FLINK-3636] Add ThrottledIterator to WindowJoin jar"
> >>
> https://github.com/apache/flink/commit/f09d68a05efb4afeb7b8498d35201e8324d6c096
> >>
> >> From the pull requests I would include:
> >> "[FLINK-3651] Fix faulty RollingSink Restore"
> >> https://github.com/apache/flink/pull/1830
> >>
> >> Anything else?
> >>
> >> I would like to manage the release, but I'm on vacation next week, so I
> >> think somebody else should do it ;)
> >>
> >>
> >> On Wed, Mar 23, 2016 at 2:18 PM, Maximilian Michels <[hidden email]>
> wrote:
> >>
> >>> +1
> >>>
> >>> On Wed, Mar 23, 2016 at 12:19 PM, Till Rohrmann <[hidden email]>
> >>> wrote:
> >>>> +1
> >>>>
> >>>> On Wed, Mar 23, 2016 at 11:24 AM, Stephan Ewen <[hidden email]>
> wrote:
> >>>>
> >>>>> Yes, there is also the Rich Scala Window Functions, and the tests
> that
> >>> used
> >>>>> to address wrong JAR directories.
> >>>>>
> >>>>> On Wed, Mar 23, 2016 at 11:15 AM, Ufuk Celebi <[hidden email]>
> wrote:
> >>>>>
> >>>>>> Big +1, let's get this rolling... ;)
> >>>>>>
> >>>>>> On Wed, Mar 23, 2016 at 11:14 AM, Aljoscha Krettek <
> >>> [hidden email]>
> >>>>>> wrote:
> >>>>>>> Hi,
> >>>>>>> I’m aware of one critical fix and one somewhat critical fix since
> >>>>> 1.0.0.
> >>>>>> One concerns data loss in the RollingSink, the other is a bug in a
> >>> window
> >>>>>> trigger. I would like to release a bugfix release since some people
> >>> are
> >>>>>> restricted to using released versions and are also depending on the
> >>>>>> RollingSink. For them, now having a bugfix release would be a
> blocker.
> >>>>>>>
> >>>>>>> What do you think? Are there any other critical bugs/fixes that we
> >>> are
> >>>>>> aware of?
> >>>>>>>
> >>>>>>> Best,
> >>>>>>> Aljoscha
> >>>>>>
> >>>>>
> >>>
> >
>

[Ufuk Celebi-2]

Hey Suneel,

From what I understand it is possible to work around the missing
method by implementing it yourself (or copying the map partition
implementation).

Would it be OK for you to just do that and wait for the 1.1 release?

– Ufuk

On Tue, Mar 29, 2016 at 7:21 PM, Suneel Marthi <[hidden email]> wrote:

> what about PR# 1829? We need it real bad for an upcoming release.
>
> On Tue, Mar 29, 2016 at 1:17 PM, Ufuk Celebi <[hidden email]> wrote:
>
>> I just merged #1830 and will create a RC after cherry picking
>> '[FLINK-3636] Add ThrottledIterator to WindowJoin jar' to the
>> release-1.0 branch.
>>
>> Thanks for kicking off the discussion Aljoscha!
>>
>> – Ufuk
>>
>> On Thu, Mar 24, 2016 at 5:07 AM, Chiwan Park <[hidden email]>
>> wrote:
>> > +1
>> >
>> > Regards,
>> > Chiwan Park
>> >
>> >> On Mar 23, 2016, at 11:24 PM, Robert Metzger <[hidden email]>
>> wrote:
>> >>
>> >> +1
>> >>
>> >> I just went through the master and release-1.0 branch, and most
>> important
>> >> fixes are already in the release-1.0 branch.
>> >> I would also move this commit into the release branch:
>> >> "[FLINK-3636] Add ThrottledIterator to WindowJoin jar"
>> >>
>> https://github.com/apache/flink/commit/f09d68a05efb4afeb7b8498d35201e8324d6c096
>> >>
>> >> From the pull requests I would include:
>> >> "[FLINK-3651] Fix faulty RollingSink Restore"
>> >> https://github.com/apache/flink/pull/1830
>> >>
>> >> Anything else?
>> >>
>> >> I would like to manage the release, but I'm on vacation next week, so I
>> >> think somebody else should do it ;)
>> >>
>> >>
>> >> On Wed, Mar 23, 2016 at 2:18 PM, Maximilian Michels <[hidden email]>
>> wrote:
>> >>
>> >>> +1
>> >>>
>> >>> On Wed, Mar 23, 2016 at 12:19 PM, Till Rohrmann <[hidden email]>
>> >>> wrote:
>> >>>> +1
>> >>>>
>> >>>> On Wed, Mar 23, 2016 at 11:24 AM, Stephan Ewen <[hidden email]>
>> wrote:
>> >>>>
>> >>>>> Yes, there is also the Rich Scala Window Functions, and the tests
>> that
>> >>> used
>> >>>>> to address wrong JAR directories.
>> >>>>>
>> >>>>> On Wed, Mar 23, 2016 at 11:15 AM, Ufuk Celebi <[hidden email]>
>> wrote:
>> >>>>>
>> >>>>>> Big +1, let's get this rolling... ;)
>> >>>>>>
>> >>>>>> On Wed, Mar 23, 2016 at 11:14 AM, Aljoscha Krettek <
>> >>> [hidden email]>
>> >>>>>> wrote:
>> >>>>>>> Hi,
>> >>>>>>> I’m aware of one critical fix and one somewhat critical fix since
>> >>>>> 1.0.0.
>> >>>>>> One concerns data loss in the RollingSink, the other is a bug in a
>> >>> window
>> >>>>>> trigger. I would like to release a bugfix release since some people
>> >>> are
>> >>>>>> restricted to using released versions and are also depending on the
>> >>>>>> RollingSink. For them, now having a bugfix release would be a
>> blocker.
>> >>>>>>>
>> >>>>>>> What do you think? Are there any other critical bugs/fixes that we
>> >>> are
>> >>>>>> aware of?
>> >>>>>>>
>> >>>>>>> Best,
>> >>>>>>> Aljoscha
>> >>>>>>
>> >>>>>
>> >>>
>> >
>>

[Márton Balassi]

Just a quick note: "[FLINK-3636] Add ThrottledIterator to WindowJoin jar"
is not needed on the release-1,0 branch as the example rewrite introducing
the ThrottledIterator is not present there. I see that Ufuk has already
pushed the commit there, it does no harm after all.

On Wed, Mar 30, 2016 at 10:25 AM, Ufuk Celebi <[hidden email]> wrote:

> Hey Suneel,
>
> From what I understand it is possible to work around the missing
> method by implementing it yourself (or copying the map partition
> implementation).
>
> Would it be OK for you to just do that and wait for the 1.1 release?
>
> – Ufuk
>
> On Tue, Mar 29, 2016 at 7:21 PM, Suneel Marthi <[hidden email]> wrote:
> > what about PR# 1829? We need it real bad for an upcoming release.
> >
> > On Tue, Mar 29, 2016 at 1:17 PM, Ufuk Celebi <[hidden email]> wrote:
> >
> >> I just merged #1830 and will create a RC after cherry picking
> >> '[FLINK-3636] Add ThrottledIterator to WindowJoin jar' to the
> >> release-1.0 branch.
> >>
> >> Thanks for kicking off the discussion Aljoscha!
> >>
> >> – Ufuk
> >>
> >> On Thu, Mar 24, 2016 at 5:07 AM, Chiwan Park <[hidden email]>
> >> wrote:
> >> > +1
> >> >
> >> > Regards,
> >> > Chiwan Park
> >> >
> >> >> On Mar 23, 2016, at 11:24 PM, Robert Metzger <[hidden email]>
> >> wrote:
> >> >>
> >> >> +1
> >> >>
> >> >> I just went through the master and release-1.0 branch, and most
> >> important
> >> >> fixes are already in the release-1.0 branch.
> >> >> I would also move this commit into the release branch:
> >> >> "[FLINK-3636] Add ThrottledIterator to WindowJoin jar"
> >> >>
> >>
> https://github.com/apache/flink/commit/f09d68a05efb4afeb7b8498d35201e8324d6c096
> >> >>
> >> >> From the pull requests I would include:
> >> >> "[FLINK-3651] Fix faulty RollingSink Restore"
> >> >> https://github.com/apache/flink/pull/1830
> >> >>
> >> >> Anything else?
> >> >>
> >> >> I would like to manage the release, but I'm on vacation next week,
> so I
> >> >> think somebody else should do it ;)
> >> >>
> >> >>
> >> >> On Wed, Mar 23, 2016 at 2:18 PM, Maximilian Michels <[hidden email]>
> >> wrote:
> >> >>
> >> >>> +1
> >> >>>
> >> >>> On Wed, Mar 23, 2016 at 12:19 PM, Till Rohrmann <
> [hidden email]>
> >> >>> wrote:
> >> >>>> +1
> >> >>>>
> >> >>>> On Wed, Mar 23, 2016 at 11:24 AM, Stephan Ewen <[hidden email]>
> >> wrote:
> >> >>>>
> >> >>>>> Yes, there is also the Rich Scala Window Functions, and the tests
> >> that
> >> >>> used
> >> >>>>> to address wrong JAR directories.
> >> >>>>>
> >> >>>>> On Wed, Mar 23, 2016 at 11:15 AM, Ufuk Celebi <[hidden email]>
> >> wrote:
> >> >>>>>
> >> >>>>>> Big +1, let's get this rolling... ;)
> >> >>>>>>
> >> >>>>>> On Wed, Mar 23, 2016 at 11:14 AM, Aljoscha Krettek <
> >> >>> [hidden email]>
> >> >>>>>> wrote:
> >> >>>>>>> Hi,
> >> >>>>>>> I’m aware of one critical fix and one somewhat critical fix
> since
> >> >>>>> 1.0.0.
> >> >>>>>> One concerns data loss in the RollingSink, the other is a bug in
> a
> >> >>> window
> >> >>>>>> trigger. I would like to release a bugfix release since some
> people
> >> >>> are
> >> >>>>>> restricted to using released versions and are also depending on
> the
> >> >>>>>> RollingSink. For them, now having a bugfix release would be a
> >> blocker.
> >> >>>>>>>
> >> >>>>>>> What do you think? Are there any other critical bugs/fixes that
> we
> >> >>> are
> >> >>>>>> aware of?
> >> >>>>>>>
> >> >>>>>>> Best,
> >> >>>>>>> Aljoscha
> >> >>>>>>
> >> >>>>>
> >> >>>
> >> >
> >>
>