Hi, all
The Flink distribution’s directory have no very clear responsibility about what type of files should be in which directory. The "bin","conf","lib" directories are clear for their responsibility. But the “opt" directories are mixed with library jars and example jars. I think we can discuss how is reasonable for the directory. Once we determined, we should follow it. IMO, directory style below is reasonable: - "examples" directory only contain example jars - "opt" directory only contain optional library jars in runtime - "lib" directory only contain library jar that must be loaded at runtime - “resources” directory only contain resource file used at runtime, such as web file Show your opinion please. @wuchong, @fhueske @Fabian Best regards, Jinkui Shi . ├── LICENSE ├── NOTICE ├── README.txt ├── bin │ ├── config.sh │ ├── flink │ ├── ... ├── conf │ ├── flink-conf.yaml │ ├── ... ├── examples │ ├── batch │ └── streaming ├── lib │ ├── flink-dist_2.11-1.3.0.jar │ ├── flink-python_2.11-1.3.0.jar │ ├── ... ├── log ├── opt │ ├── flink-cep-scala_2.11-1.3.0.jar │ ├── flink-cep_2.11-1.3.0.jar │ ├── flink-gelly-examples_2.11-1.3.0.jar │ ├── flink-gelly-scala_2.11-1.3.0.jar │ ├── flink-gelly_2.11-1.3.0.jar │ ├── flink-metrics-dropwizard-1.3.0.jar │ ├── flink-metrics-ganglia-1.3.0.jar │ ├── flink-metrics-graphite-1.3.0.jar │ ├── flink-metrics-statsd-1.3.0.jar │ └── flink-ml_2.11-1.3.0.jar ├── resources │ └── python └── tools └── planVisualizer.html [1] https://github.com/apache/flink/pull/2460 |
Hi Jinkui,
+1 to moving gelly-examples into examples/. Also sounds nice to similarly organize the Python examples. Docs will also need to be updated (docs/dev/lib/gelly/index.md). Greg > On Mar 25, 2017, at 3:46 AM, shijinkui <[hidden email]> wrote: > > Hi, all > > The Flink distributionĄ¯s directory have no very clear responsibility about what type of files should be in which directory. > > The "bin","conf","lib" directories are clear for their responsibility. > > But the Ą°opt" directories are mixed with library jars and example jars. > > I think we can discuss how is reasonable for the directory. Once we determined, we should follow it. > > IMO, directory style below is reasonable: > > - "examples" directory only contain example jars > - "opt" directory only contain optional library jars in runtime > - "lib" directory only contain library jar that must be loaded at runtime > - Ą°resourcesĄą directory only contain resource file used at runtime, such as web file > > Show your opinion please. > > @wuchong, @fhueske @Fabian > > Best regards, > Jinkui Shi > > > . > ŠĀФФ LICENSE > ŠĀФФ NOTICE > ŠĀФФ README.txt > ŠĀФФ bin > ŠĻ ŠĀФФ config.sh > ŠĻ ŠĀФФ flink > ŠĻ ŠĀФФ ... > ŠĀФФ conf > ŠĻ ŠĀФФ flink-conf.yaml > ŠĻ ŠĀФФ ... > ŠĀФФ examples > ŠĻ ŠĀФФ batch > ŠĻ ЏФФ streaming > ŠĀФФ lib > ŠĻ ŠĀФФ flink-dist_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-python_2.11-1.3.0.jar > ŠĻ ŠĀФФ ... > ŠĀФФ log > ŠĀФФ opt > ŠĻ ŠĀФФ flink-cep-scala_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-cep_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-gelly-examples_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-gelly-scala_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-gelly_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-metrics-dropwizard-1.3.0.jar > ŠĻ ŠĀФФ flink-metrics-ganglia-1.3.0.jar > ŠĻ ŠĀФФ flink-metrics-graphite-1.3.0.jar > ŠĻ ŠĀФФ flink-metrics-statsd-1.3.0.jar > ŠĻ ЏФФ flink-ml_2.11-1.3.0.jar > ŠĀФФ resources > ŠĻ ЏФФ python > ЏФФ tools > ЏФФ planVisualizer.html > > > [1] https://github.com/apache/flink/pull/2460 > |
In reply to this post by shijinkui
Hi Jinkui,
Thanks for bringing up this discussion. I’m +1 to moving table-examples and belly-examples into "examples/“ to keep “opt” clean. Best, Jark Wu > 在 2017年3月25日,下午3:46,shijinkui <[hidden email]> 写道: > > Hi, all > > The Flink distributionĄ¯s directory have no very clear responsibility about what type of files should be in which directory. > > The "bin","conf","lib" directories are clear for their responsibility. > > But the Ą°opt" directories are mixed with library jars and example jars. > > I think we can discuss how is reasonable for the directory. Once we determined, we should follow it. > > IMO, directory style below is reasonable: > > - "examples" directory only contain example jars > - "opt" directory only contain optional library jars in runtime > - "lib" directory only contain library jar that must be loaded at runtime > - Ą°resourcesĄą directory only contain resource file used at runtime, such as web file > > Show your opinion please. > > @wuchong, @fhueske @Fabian > > Best regards, > Jinkui Shi > > > . > ŠĀФФ LICENSE > ŠĀФФ NOTICE > ŠĀФФ README.txt > ŠĀФФ bin > ŠĻ ŠĀФФ config.sh > ŠĻ ŠĀФФ flink > ŠĻ ŠĀФФ ... > ŠĀФФ conf > ŠĻ ŠĀФФ flink-conf.yaml > ŠĻ ŠĀФФ ... > ŠĀФФ examples > ŠĻ ŠĀФФ batch > ŠĻ ЏФФ streaming > ŠĀФФ lib > ŠĻ ŠĀФФ flink-dist_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-python_2.11-1.3.0.jar > ŠĻ ŠĀФФ ... > ŠĀФФ log > ŠĀФФ opt > ŠĻ ŠĀФФ flink-cep-scala_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-cep_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-gelly-examples_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-gelly-scala_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-gelly_2.11-1.3.0.jar > ŠĻ ŠĀФФ flink-metrics-dropwizard-1.3.0.jar > ŠĻ ŠĀФФ flink-metrics-ganglia-1.3.0.jar > ŠĻ ŠĀФФ flink-metrics-graphite-1.3.0.jar > ŠĻ ŠĀФФ flink-metrics-statsd-1.3.0.jar > ŠĻ ЏФФ flink-ml_2.11-1.3.0.jar > ŠĀФФ resources > ŠĻ ЏФФ python > ЏФФ tools > ЏФФ planVisualizer.html > > > [1] https://github.com/apache/flink/pull/2460 > |
Hi Jinkui,
I agree with you, moving all examples into ./examples would be nice. Note, that for the DataSet and DataStream APIs, each example is packaged as a separate JAR with the main class being included in the MANIFEST file. I think we should select a few representative examples of the Table and Gelly examples and do the same. IMO, the Table API / SQL examples could also be improved a lot, but that's a different story. Best, Fabian 2017-03-27 5:47 GMT+02:00 伍翀(云邪) <[hidden email]>: > Hi Jinkui, > > Thanks for bringing up this discussion. I’m +1 to moving table-examples > and belly-examples into "examples/“ to keep “opt” clean. > > Best, > Jark Wu > > > 在 2017年3月25日,下午3:46,shijinkui <[hidden email]> 写道: > > > > Hi, all > > > > The Flink distributionĄ¯s directory have no very clear responsibility > about what type of files should be in which directory. > > > > The "bin","conf","lib" directories are clear for their responsibility. > > > > But the Ą°opt" directories are mixed with library jars and example jars. > > > > I think we can discuss how is reasonable for the directory. Once we > determined, we should follow it. > > > > IMO, directory style below is reasonable: > > > > - "examples" directory only contain example jars > > - "opt" directory only contain optional library jars in runtime > > - "lib" directory only contain library jar that must be loaded at runtime > > - Ą°resourcesĄą directory only contain resource file used at runtime, > such as web file > > > > Show your opinion please. > > > > @wuchong, @fhueske @Fabian > > > > Best regards, > > Jinkui Shi > > > > > > . > > ŠĀФФ LICENSE > > ŠĀФФ NOTICE > > ŠĀФФ README.txt > > ŠĀФФ bin > > ŠĻ ŠĀФФ config.sh > > ŠĻ ŠĀФФ flink > > ŠĻ ŠĀФФ ... > > ŠĀФФ conf > > ŠĻ ŠĀФФ flink-conf.yaml > > ŠĻ ŠĀФФ ... > > ŠĀФФ examples > > ŠĻ ŠĀФФ batch > > ŠĻ ЏФФ streaming > > ŠĀФФ lib > > ŠĻ ŠĀФФ flink-dist_2.11-1.3.0.jar > > ŠĻ ŠĀФФ flink-python_2.11-1.3.0.jar > > ŠĻ ŠĀФФ ... > > ŠĀФФ log > > ŠĀФФ opt > > ŠĻ ŠĀФФ flink-cep-scala_2.11-1.3.0.jar > > ŠĻ ŠĀФФ flink-cep_2.11-1.3.0.jar > > ŠĻ ŠĀФФ flink-gelly-examples_2.11-1.3.0.jar > > ŠĻ ŠĀФФ flink-gelly-scala_2.11-1.3.0.jar > > ŠĻ ŠĀФФ flink-gelly_2.11-1.3.0.jar > > ŠĻ ŠĀФФ flink-metrics-dropwizard-1.3.0.jar > > ŠĻ ŠĀФФ flink-metrics-ganglia-1.3.0.jar > > ŠĻ ŠĀФФ flink-metrics-graphite-1.3.0.jar > > ŠĻ ŠĀФФ flink-metrics-statsd-1.3.0.jar > > ŠĻ ЏФФ flink-ml_2.11-1.3.0.jar > > ŠĀФФ resources > > ŠĻ ЏФФ python > > ЏФФ tools > > ЏФФ planVisualizer.html > > > > > > [1] https://github.com/apache/flink/pull/2460 > > > > |
Hi, Fabian, Jark Wu, Greg
Thank for your feedback and support. I’ll create some sub-issue to complete the every task of code refactor. 在 2017/3/27 下午3:38, "Fabian Hueske" <[hidden email]> 写入: >Hi Jinkui, > >I agree with you, moving all examples into ./examples would be nice. >Note, that for the DataSet and DataStream APIs, each example is packaged >as >a separate JAR with the main class being included in the MANIFEST file. > >I think we should select a few representative examples of the Table and >Gelly examples and do the same. >IMO, the Table API / SQL examples could also be improved a lot, but that's >a different story. > >Best, Fabian > >2017-03-27 5:47 GMT+02:00 伍翀(云邪) <[hidden email]>: > >> Hi Jinkui, >> >> Thanks for bringing up this discussion. I’m +1 to moving table-examples >> and belly-examples into "examples/“ to keep “opt” clean. >> >> Best, >> Jark Wu >> >> > 在 2017年3月25日,下午3:46,shijinkui <[hidden email]> 写道: >> > >> > Hi, all >> > >> > The Flink distributionĄ¯s directory have no very clear responsibility >> about what type of files should be in which directory. >> > >> > The "bin","conf","lib" directories are clear for their responsibility. >> > >> > But the Ą°opt" directories are mixed with library jars and example >>jars. >> > >> > I think we can discuss how is reasonable for the directory. Once we >> determined, we should follow it. >> > >> > IMO, directory style below is reasonable: >> > >> > - "examples" directory only contain example jars >> > - "opt" directory only contain optional library jars in runtime >> > - "lib" directory only contain library jar that must be loaded at >>runtime >> > - Ą°resourcesĄą directory only contain resource file used at runtime, >> such as web file >> > >> > Show your opinion please. >> > >> > @wuchong, @fhueske @Fabian >> > >> > Best regards, >> > Jinkui Shi >> > >> > >> > . >> > ŠĀФФ LICENSE >> > ŠĀФФ NOTICE >> > ŠĀФФ README.txt >> > ŠĀФФ bin >> > ŠĻ ŠĀФФ config.sh >> > ŠĻ ŠĀФФ flink >> > ŠĻ ŠĀФФ ... >> > ŠĀФФ conf >> > ŠĻ ŠĀФФ flink-conf.yaml >> > ŠĻ ŠĀФФ ... >> > ŠĀФФ examples >> > ŠĻ ŠĀФФ batch >> > ŠĻ ЏФФ streaming >> > ŠĀФФ lib >> > ŠĻ ŠĀФФ flink-dist_2.11-1.3.0.jar >> > ŠĻ ŠĀФФ flink-python_2.11-1.3.0.jar >> > ŠĻ ŠĀФФ ... >> > ŠĀФФ log >> > ŠĀФФ opt >> > ŠĻ ŠĀФФ flink-cep-scala_2.11-1.3.0.jar >> > ŠĻ ŠĀФФ flink-cep_2.11-1.3.0.jar >> > ŠĻ ŠĀФФ flink-gelly-examples_2.11-1.3.0.jar >> > ŠĻ ŠĀФФ flink-gelly-scala_2.11-1.3.0.jar >> > ŠĻ ŠĀФФ flink-gelly_2.11-1.3.0.jar >> > ŠĻ ŠĀФФ flink-metrics-dropwizard-1.3.0.jar >> > ŠĻ ŠĀФФ flink-metrics-ganglia-1.3.0.jar >> > ŠĻ ŠĀФФ flink-metrics-graphite-1.3.0.jar >> > ŠĻ ŠĀФФ flink-metrics-statsd-1.3.0.jar >> > ŠĻ ЏФФ flink-ml_2.11-1.3.0.jar >> > ŠĀФФ resources >> > ŠĻ ЏФФ python >> > ЏФФ tools >> > ЏФФ planVisualizer.html >> > >> > >> > [1] https://github.com/apache/flink/pull/2460 >> > >> >> |
Free forum by Nabble | Edit this page |