[DISCUSS] Bump required Maven version to 3.1.1 (from 3.0.3)

[Robert Metzger]

Hey,

I recently merged the new Flink UI [1]. After merging it, I was made aware
that the frontend-maven-plugin requires at least Maven 3.1.0.
There was a discussion about bumping the maven version already last year
[2]. In that thread, Stephan mentions that some Linux distributions still
have Maven 3.0.5 as their default version.
Ubuntu 16.04 (the current LTS version) ships Maven 3.3.9.
Debian Jessie (8) is indeed still shipping 3.0.5, Stretch (9) is on 3.3.9
too.

Given this situation, I propose to bump the required Maven version to 3.1.1.

Flink releases are build with 3.2.5.

If nobody raises any objections till Thursday, May 2nd, I'll open a PR
bumping the version.

Best,
Robert


[1] https://github.com/apache/flink/pull/8016
[2] https://github.com/apache/flink/pull/6443#issuecomment-410673911

[vino yang]

Hi Robert,

+1 for your proposal.

Best,
Vino

Robert Metzger <[hidden email]> 于2019年4月26日周五 下午9:43写道：

> Hey,
>
> I recently merged the new Flink UI [1]. After merging it, I was made aware
> that the frontend-maven-plugin requires at least Maven 3.1.0.
> There was a discussion about bumping the maven version already last year
> [2]. In that thread, Stephan mentions that some Linux distributions still
> have Maven 3.0.5 as their default version.
> Ubuntu 16.04 (the current LTS version) ships Maven 3.3.9.
> Debian Jessie (8) is indeed still shipping 3.0.5, Stretch (9) is on 3.3.9
> too.
>
> Given this situation, I propose to bump the required Maven version to
> 3.1.1.
>
> Flink releases are build with 3.2.5.
>
> If nobody raises any objections till Thursday, May 2nd, I'll open a PR
> bumping the version.
>
> Best,
> Robert
>
>
> [1] https://github.com/apache/flink/pull/8016
> [2] https://github.com/apache/flink/pull/6443#issuecomment-410673911
>

[Visser, M.J.H. (Martijn)]

Hi Robert,

Just as an FYI, Redhat 7 Enterprise also still ships with 3.0.5 as default. I did a manual upgrade to a later version on one of our Redhat servers, but it appears that this plugin doesn't use the repositories as are defined in a settings.xml, but tries to setup an external connection (which fails, because we're behind a proxy).

Best regards,

Martijn

-----Original Message-----
From: Robert Metzger [mailto:[hidden email]]
Sent: vrijdag 26 april 2019 15:43
To: dev <[hidden email]>
Subject: [DISCUSS] Bump required Maven version to 3.1.1 (from 3.0.3)

Hey,

I recently merged the new Flink UI [1]. After merging it, I was made aware that the frontend-maven-plugin requires at least Maven 3.1.0.
There was a discussion about bumping the maven version already last year [2]. In that thread, Stephan mentions that some Linux distributions still have Maven 3.0.5 as their default version.
Ubuntu 16.04 (the current LTS version) ships Maven 3.3.9.
Debian Jessie (8) is indeed still shipping 3.0.5, Stretch (9) is on 3.3.9 too.

Given this situation, I propose to bump the required Maven version to 3.1.1.

Flink releases are build with 3.2.5.

If nobody raises any objections till Thursday, May 2nd, I'll open a PR bumping the version.

Best,
Robert


[1] https://github.com/apache/flink/pull/8016
[2] https://github.com/apache/flink/pull/6443#issuecomment-410673911

-----------------------------------------------------------------
ATTENTION:
The information in this e-mail is confidential and only meant for the intended recipient. If you are not the intended recipient, don't use or disclose it in any way. Please let the sender know and delete the message immediately.
-----------------------------------------------------------------

[Chesnay Schepler-3]

The other connection you're referring to is likely the plugin
downloading dependencies from npm.

On 29/04/2019 13:50, Visser, M.J.H. (Martijn) wrote:

> Hi Robert,
>
> Just as an FYI, Redhat 7 Enterprise also still ships with 3.0.5 as default. I did a manual upgrade to a later version on one of our Redhat servers, but it appears that this plugin doesn't use the repositories as are defined in a settings.xml, but tries to setup an external connection (which fails, because we're behind a proxy).
>
> Best regards,
>
> Martijn
>
> -----Original Message-----
> From: Robert Metzger [mailto:[hidden email]]
> Sent: vrijdag 26 april 2019 15:43
> To: dev <[hidden email]>
> Subject: [DISCUSS] Bump required Maven version to 3.1.1 (from 3.0.3)
>
> Hey,
>
> I recently merged the new Flink UI [1]. After merging it, I was made aware that the frontend-maven-plugin requires at least Maven 3.1.0.
> There was a discussion about bumping the maven version already last year [2]. In that thread, Stephan mentions that some Linux distributions still have Maven 3.0.5 as their default version.
> Ubuntu 16.04 (the current LTS version) ships Maven 3.3.9.
> Debian Jessie (8) is indeed still shipping 3.0.5, Stretch (9) is on 3.3.9 too.
>
> Given this situation, I propose to bump the required Maven version to 3.1.1.
>
> Flink releases are build with 3.2.5.
>
> If nobody raises any objections till Thursday, May 2nd, I'll open a PR bumping the version.
>
> Best,
> Robert
>
>
> [1] https://github.com/apache/flink/pull/8016
> [2] https://github.com/apache/flink/pull/6443#issuecomment-410673911
>
> -----------------------------------------------------------------
> ATTENTION:
> The information in this e-mail is confidential and only meant for the intended recipient. If you are not the intended recipient, don't use or disclose it in any way. Please let the sender know and delete the message immediately.
> -----------------------------------------------------------------

[Robert Metzger]

Thanks Martijn. RHEL has quite long support cycles :)

Would you still be okay with the version bump?
(The workaround here being to manually download a later maven version for
Flink builds)

For the npm dependencies: Is Flink the only npm project build on these
servers? (I'm asking because there might be a similar model with custom
repositories for npm, or some exceptions in your corporate policies for
NPM?)

On Mon, Apr 29, 2019 at 4:23 PM Chesnay Schepler <[hidden email]> wrote:

> The other connection you're referring to is likely the plugin
> downloading dependencies from npm.
>
> On 29/04/2019 13:50, Visser, M.J.H. (Martijn) wrote:
> > Hi Robert,
> >
> > Just as an FYI, Redhat 7 Enterprise also still ships with 3.0.5 as
> default. I did a manual upgrade to a later version on one of our Redhat
> servers, but it appears that this plugin doesn't use the repositories as
> are defined in a settings.xml, but tries to setup an external connection
> (which fails, because we're behind a proxy).
> >
> > Best regards,
> >
> > Martijn
> >
> > -----Original Message-----
> > From: Robert Metzger [mailto:[hidden email]]
> > Sent: vrijdag 26 april 2019 15:43
> > To: dev <[hidden email]>
> > Subject: [DISCUSS] Bump required Maven version to 3.1.1 (from 3.0.3)
> >
> > Hey,
> >
> > I recently merged the new Flink UI [1]. After merging it, I was made
> aware that the frontend-maven-plugin requires at least Maven 3.1.0.
> > There was a discussion about bumping the maven version already last year
> [2]. In that thread, Stephan mentions that some Linux distributions still
> have Maven 3.0.5 as their default version.
> > Ubuntu 16.04 (the current LTS version) ships Maven 3.3.9.
> > Debian Jessie (8) is indeed still shipping 3.0.5, Stretch (9) is on
> 3.3.9 too.
> >
> > Given this situation, I propose to bump the required Maven version to
> 3.1.1.
> >
> > Flink releases are build with 3.2.5.
> >
> > If nobody raises any objections till Thursday, May 2nd, I'll open a PR
> bumping the version.
> >
> > Best,
> > Robert
> >
> >
> > [1] https://github.com/apache/flink/pull/8016
> > [2] https://github.com/apache/flink/pull/6443#issuecomment-410673911
> >
> > -----------------------------------------------------------------
> > ATTENTION:
> > The information in this e-mail is confidential and only meant for the
> intended recipient. If you are not the intended recipient, don't use or
> disclose it in any way. Please let the sender know and delete the message
> immediately.
> > -----------------------------------------------------------------
>
>
>

[Visser, M.J.H. (Martijn)]

I wouldn't consider the version bump blocking for us. We do have Redhat machines for local development, but we can manually upgrade the Maven version there.

Yes, Flink is the only npm project build on those machines. There are other projects though that are using npm, so we'll probably can get it working internally too. Just requires some more manual work.

-----Original Message-----
From: Robert Metzger [mailto:[hidden email]]
Sent: maandag 29 april 2019 17:32
To: dev <[hidden email]>
Cc: Visser, M.J.H. (Martijn) <[hidden email]>
Subject: Re: [DISCUSS] Bump required Maven version to 3.1.1 (from 3.0.3)

Thanks Martijn. RHEL has quite long support cycles :)

Would you still be okay with the version bump?
(The workaround here being to manually download a later maven version for Flink builds)

For the npm dependencies: Is Flink the only npm project build on these servers? (I'm asking because there might be a similar model with custom repositories for npm, or some exceptions in your corporate policies for
NPM?)

On Mon, Apr 29, 2019 at 4:23 PM Chesnay Schepler <[hidden email]> wrote:

> The other connection you're referring to is likely the plugin
> downloading dependencies from npm.
>
> On 29/04/2019 13:50, Visser, M.J.H. (Martijn) wrote:
> > Hi Robert,
> >
> > Just as an FYI, Redhat 7 Enterprise also still ships with 3.0.5 as
> default. I did a manual upgrade to a later version on one of our
> Redhat servers, but it appears that this plugin doesn't use the
> repositories as are defined in a settings.xml, but tries to setup an
> external connection (which fails, because we're behind a proxy).
> >
> > Best regards,
> >
> > Martijn
> >
> > -----Original Message-----
> > From: Robert Metzger [mailto:[hidden email]]
> > Sent: vrijdag 26 april 2019 15:43
> > To: dev <[hidden email]>
> > Subject: [DISCUSS] Bump required Maven version to 3.1.1 (from 3.0.3)
> >
> > Hey,
> >
> > I recently merged the new Flink UI [1]. After merging it, I was made
> aware that the frontend-maven-plugin requires at least Maven 3.1.0.
> > There was a discussion about bumping the maven version already last
> > year
> [2]. In that thread, Stephan mentions that some Linux distributions
> still have Maven 3.0.5 as their default version.
> > Ubuntu 16.04 (the current LTS version) ships Maven 3.3.9.
> > Debian Jessie (8) is indeed still shipping 3.0.5, Stretch (9) is on
> 3.3.9 too.
> >
> > Given this situation, I propose to bump the required Maven version
> > to
> 3.1.1.
> >
> > Flink releases are build with 3.2.5.
> >
> > If nobody raises any objections till Thursday, May 2nd, I'll open a
> > PR
> bumping the version.
> >
> > Best,
> > Robert
> >
> >
> > [1] https://github.com/apache/flink/pull/8016
> > [2] https://github.com/apache/flink/pull/6443#issuecomment-410673911
> >
> > -----------------------------------------------------------------
> > ATTENTION:
> > The information in this e-mail is confidential and only meant for
> > the
> intended recipient. If you are not the intended recipient, don't use
> or disclose it in any way. Please let the sender know and delete the
> message immediately.
> > -----------------------------------------------------------------
>
>
>

-----------------------------------------------------------------
ATTENTION:
The information in this e-mail is confidential and only meant for the intended recipient. If you are not the intended recipient, don't use or disclose it in any way. Please let the sender know and delete the message immediately.
-----------------------------------------------------------------

[Robert Metzger]

Thanks for your feedback. I'll open a PR.

Here's the ticket: https://issues.apache.org/jira/browse/FLINK-12447

On Tue, Apr 30, 2019 at 11:33 AM Visser, M.J.H. (Martijn)
<[hidden email]> wrote:

> I wouldn't consider the version bump blocking for us. We do have Redhat
> machines for local development, but we can manually upgrade the Maven
> version there.
>
> Yes, Flink is the only npm project build on those machines. There are
> other projects though that are using npm, so we'll probably can get it
> working internally too. Just requires some more manual work.
>
> -----Original Message-----
> From: Robert Metzger [mailto:[hidden email]]
> Sent: maandag 29 april 2019 17:32
> To: dev <[hidden email]>
> Cc: Visser, M.J.H. (Martijn) <[hidden email]>
> Subject: Re: [DISCUSS] Bump required Maven version to 3.1.1 (from 3.0.3)
>
> Thanks Martijn. RHEL has quite long support cycles :)
>
> Would you still be okay with the version bump?
> (The workaround here being to manually download a later maven version for
> Flink builds)
>
> For the npm dependencies: Is Flink the only npm project build on these
> servers? (I'm asking because there might be a similar model with custom
> repositories for npm, or some exceptions in your corporate policies for
> NPM?)
>
> On Mon, Apr 29, 2019 at 4:23 PM Chesnay Schepler <[hidden email]>
> wrote:
>
> > The other connection you're referring to is likely the plugin
> > downloading dependencies from npm.
> >
> > On 29/04/2019 13:50, Visser, M.J.H. (Martijn) wrote:
> > > Hi Robert,
> > >
> > > Just as an FYI, Redhat 7 Enterprise also still ships with 3.0.5 as
> > default. I did a manual upgrade to a later version on one of our
> > Redhat servers, but it appears that this plugin doesn't use the
> > repositories as are defined in a settings.xml, but tries to setup an
> > external connection (which fails, because we're behind a proxy).
> > >
> > > Best regards,
> > >
> > > Martijn
> > >
> > > -----Original Message-----
> > > From: Robert Metzger [mailto:[hidden email]]
> > > Sent: vrijdag 26 april 2019 15:43
> > > To: dev <[hidden email]>
> > > Subject: [DISCUSS] Bump required Maven version to 3.1.1 (from 3.0.3)
> > >
> > > Hey,
> > >
> > > I recently merged the new Flink UI [1]. After merging it, I was made
> > aware that the frontend-maven-plugin requires at least Maven 3.1.0.
> > > There was a discussion about bumping the maven version already last
> > > year
> > [2]. In that thread, Stephan mentions that some Linux distributions
> > still have Maven 3.0.5 as their default version.
> > > Ubuntu 16.04 (the current LTS version) ships Maven 3.3.9.
> > > Debian Jessie (8) is indeed still shipping 3.0.5, Stretch (9) is on
> > 3.3.9 too.
> > >
> > > Given this situation, I propose to bump the required Maven version
> > > to
> > 3.1.1.
> > >
> > > Flink releases are build with 3.2.5.
> > >
> > > If nobody raises any objections till Thursday, May 2nd, I'll open a
> > > PR
> > bumping the version.
> > >
> > > Best,
> > > Robert
> > >
> > >
> > > [1] https://github.com/apache/flink/pull/8016
> > > [2] https://github.com/apache/flink/pull/6443#issuecomment-410673911
> > >
> > > -----------------------------------------------------------------
> > > ATTENTION:
> > > The information in this e-mail is confidential and only meant for
> > > the
> > intended recipient. If you are not the intended recipient, don't use
> > or disclose it in any way. Please let the sender know and delete the
> > message immediately.
> > > -----------------------------------------------------------------
> >
> >
> >
>
> -----------------------------------------------------------------
> ATTENTION:
> The information in this e-mail is confidential and only meant for the
> intended recipient. If you are not the intended recipient, don't use or
> disclose it in any way. Please let the sender know and delete the message
> immediately.
> -----------------------------------------------------------------
>