[DISCUSS] Automated code quality check in Flink

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[DISCUSS] Automated code quality check in Flink

Ivan Mushketyk
Hi!

Flink uses Travis and Jenkis to check if new PR passes unit tests, but
there are other tools that can automatically check code quality like:
https://www.codacy.com/
https://codeclimate.com/

These tools promise to track test coverage, check code style, detect code
duplication and so on.
Since they are free for Open Source projects, it seems like it could be
quite beneficial to enable them.
Have you ever tried any of them? What do you think about this?

Best regards,
Ivan.
Reply | Threaded
Open this post in threaded view
|

Re:[DISCUSS] Automated code quality check in Flink

Jinkui Shi
+1<br/>Indeed we  should pay attention to the code quality.<br/>The  confused module list also need better design.
At 2016-08-31 22:37:35, "Ivan Mushketyk" <[hidden email]> wrote:

>Hi!
>
>Flink uses Travis and Jenkis to check if new PR passes unit tests, but
>there are other tools that can automatically check code quality like:
>https://www.codacy.com/
>https://codeclimate.com/
>
>These tools promise to track test coverage, check code style, detect code
>duplication and so on.
>Since they are free for Open Source projects, it seems like it could be
>quite beneficial to enable them.
>Have you ever tried any of them? What do you think about this?
>
>Best regards,
>Ivan.
mxm
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Automated code quality check in Flink

mxm
In reply to this post by Ivan Mushketyk
Hi Ivan,

I don't have any experience with the sites but I wouldn't mind trying
out one of these. As far as I understand they help to visualize code
coverage and perform static analysis to find code problems. As for the
code coverage, we have to build in coverage checks into our build
system ourselves*.

Could you find out which of the two would be worth trying out?

Best,
Max

* For example, Codacy uses JaCoco for code voerage.

On Wed, Aug 31, 2016 at 4:37 PM, Ivan Mushketyk
<[hidden email]> wrote:

> Hi!
>
> Flink uses Travis and Jenkis to check if new PR passes unit tests, but
> there are other tools that can automatically check code quality like:
> https://www.codacy.com/
> https://codeclimate.com/
>
> These tools promise to track test coverage, check code style, detect code
> duplication and so on.
> Since they are free for Open Source projects, it seems like it could be
> quite beneficial to enable them.
> Have you ever tried any of them? What do you think about this?
>
> Best regards,
> Ivan.