Hello,
There were a few things which we missing in https://issues.apache.org/jira/browse/FLINK-12539, due to which it was not possible to extend the StreamingFileSink. To fix this I have created a follow-up PR but I am not sure if this is the best way to make these changes: https://github.com/apache/flink/compare/master...kailashhd:FLINK-12539. In case this is the best approach to do this, I will do ahead and create another JIRA and PR for this. Appreciate the help. Thanks Kailash |
Hi Kailash,
Yes, I think creating another Jira and PR would be the right thing to do. Thank you, Fabian Am Fr., 2. Aug. 2019 um 10:29 Uhr schrieb Kailash Dayanand < [hidden email]>: > Hello, > > There were a few things which we missing in > https://issues.apache.org/jira/browse/FLINK-12539, due to which it was not > possible to extend the StreamingFileSink. To fix this I have created a > follow-up PR but I am not sure if this is the best way to make these > changes: > https://github.com/apache/flink/compare/master...kailashhd:FLINK-12539. > > In case this is the best approach to do this, I will do ahead and create > another JIRA and PR for this. Appreciate the help. > > Thanks > Kailash > |
Hi Kailash,
Any update on this? Thanks, Thomas On Wed, Aug 7, 2019 at 7:54 AM Fabian Hueske <[hidden email]> wrote: > Hi Kailash, > > Yes, I think creating another Jira and PR would be the right thing to do. > > Thank you, > Fabian > > Am Fr., 2. Aug. 2019 um 10:29 Uhr schrieb Kailash Dayanand < > [hidden email]>: > > > Hello, > > > > There were a few things which we missing in > > https://issues.apache.org/jira/browse/FLINK-12539, due to which it was > not > > possible to extend the StreamingFileSink. To fix this I have created a > > follow-up PR but I am not sure if this is the best way to make these > > changes: > > https://github.com/apache/flink/compare/master...kailashhd:FLINK-12539. > > > > In case this is the best approach to do this, I will do ahead and create > > another JIRA and PR for this. Appreciate the help. > > > > Thanks > > Kailash > > > |
Apologies for the delay on this one. I have created the jira ticket and
will continue discussion there: https://issues.apache.org/jira/browse/FLINK-13864. On Sat, Aug 24, 2019 at 7:48 AM Thomas Weise <[hidden email]> wrote: > Hi Kailash, > > Any update on this? > > Thanks, > Thomas > > > On Wed, Aug 7, 2019 at 7:54 AM Fabian Hueske <[hidden email]> wrote: > >> Hi Kailash, >> >> Yes, I think creating another Jira and PR would be the right thing to do. >> >> Thank you, >> Fabian >> >> Am Fr., 2. Aug. 2019 um 10:29 Uhr schrieb Kailash Dayanand < >> [hidden email]>: >> >> > Hello, >> > >> > There were a few things which we missing in >> > https://issues.apache.org/jira/browse/FLINK-12539, due to which it was >> not >> > possible to extend the StreamingFileSink. To fix this I have created a >> > follow-up PR but I am not sure if this is the best way to make these >> > changes: >> > https://github.com/apache/flink/compare/master...kailashhd:FLINK-12539. >> > >> > In case this is the best approach to do this, I will do ahead and create >> > another JIRA and PR for this. Appreciate the help. >> > >> > Thanks >> > Kailash >> > >> > |
Free forum by Nabble | Edit this page |