Could someone please take a look at mr PR, thanks

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Could someone please take a look at mr PR, thanks

JiaTao Tao
Here I fix a potential NPE and contributed my patch, but no one reviewed
after several months (https://github.com/apache/flink/pull/12702), this PR
has conflicts, so I pull a new one (
https://github.com/apache/flink/pull/13836), would someone be nice to take
a look at this?


Regards!

Aron Tao
Reply | Threaded
Open this post in threaded view
|

Re: Could someone please take a look at mr PR, thanks

Jark Wu-2
Sorry for the late reviewing. The community is busy preparing for 1.12
release.
I guess this is the reason that this PR was missed to review.
I will help to review this PR later.

Thanks for the contribution!

Best,
Jark

On Tue, 3 Nov 2020 at 10:36, JiaTao Tao <[hidden email]> wrote:

> Here I fix a potential NPE and contributed my patch, but no one reviewed
> after several months (https://github.com/apache/flink/pull/12702), this PR
> has conflicts, so I pull a new one (
> https://github.com/apache/flink/pull/13836), would someone be nice to take
> a look at this?
>
>
> Regards!
>
> Aron Tao
>
Reply | Threaded
Open this post in threaded view
|

Re: Could someone please take a look at mr PR, thanks

JiaTao Tao
Hi Jark
Thanks a lot!


Regards!

Aron Tao


Jark Wu <[hidden email]> 于2020年11月3日周二 下午2:45写道:

> Sorry for the late reviewing. The community is busy preparing for 1.12
> release.
> I guess this is the reason that this PR was missed to review.
> I will help to review this PR later.
>
> Thanks for the contribution!
>
> Best,
> Jark
>
> On Tue, 3 Nov 2020 at 10:36, JiaTao Tao <[hidden email]> wrote:
>
> > Here I fix a potential NPE and contributed my patch, but no one reviewed
> > after several months (https://github.com/apache/flink/pull/12702), this
> PR
> > has conflicts, so I pull a new one (
> > https://github.com/apache/flink/pull/13836), would someone be nice to
> take
> > a look at this?
> >
> >
> > Regards!
> >
> > Aron Tao
> >
>