Could someone help me to review PR[12727]?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Could someone help me to review PR[12727]?

RocMarshal
Hi, all.

I have finished the first draft of this translation(https://github.com/apache/flink/pull/12727). Could someone please review it for me?

Thank you.

Best Roc.


Reply | Threaded
Open this post in threaded view
|

Re: Could someone help me to review PR[12727]?

Leonard Xu
Hi, Roc

Thanks for the contribution, I’d like to help review this PR.

Best,
Leonard Xu
Reply | Threaded
Open this post in threaded view
|

Re: Could someone help me to review PR[12727]?

Congxian Qiu
Hi Roc

Thanks for your contribution. I've reviewed it and gave some comments.
please take a look. thanks

Best,
Congxian


Leonard Xu <[hidden email]> 于2020年6月23日周二 上午10:23写道:

> Hi, Roc
>
> Thanks for the contribution, I’d like to help review this PR.
>
> Best,
> Leonard Xu
Reply | Threaded
Open this post in threaded view
|

Re:Re: Could someone help me to review PR[12727]?

RocMarshal
Hi, @klion26.<br/><br/>I have made some changes based on your suggestions, which is very helpful for improvement.<br/>And could you check it again for me  if you have free time ?<br/>Thank you so much.
在 2020-06-23 14:10:48,"Congxian Qiu" <[hidden email]> 写道:

>Hi Roc
>
>Thanks for your contribution. I've reviewed it and gave some comments.
>please take a look. thanks
>
>Best,
>Congxian
>
>
>Leonard Xu <[hidden email]> 于2020年6月23日周二 上午10:23写道:
>
>> Hi, Roc
>>
>> Thanks for the contribution, I’d like to help review this PR.
>>
>> Best,
>> Leonard Xu