Confused about method naming in heartbeatFromJobManager or heartbeatFromResourceManager

[mingleizhang]

Attached is the taskmanager design picture. And from the picturen, I know taskmanager send heartbeat to jobmanager ( also called jobmaster in flip6 now) and resourcesmanager periodically. But when I watched the source code below in TaskExecutor.java. I feel confused about the function name. Shouldn't it be heartbeatToJobManager and heartbeatToResouceManager ? And in TaskExecutorGateway.java there is a comment, Heartbeat request from job manager. yea. both them confused me a lot. Does anyone let me know why called it like that ? 

Thanks

Rice.

// ----------------------------------------------------------------------
// Heartbeat RPC
// ----------------------------------------------------------------------

@Override
public void heartbeatFromJobManager(ResourceID resourceID) {
   jobManagerHeartbeatManager.requestHeartbeat(resourceID, null);
}

@Override
public void heartbeatFromResourceManager(ResourceID resourceID) {
   resourceManagerHeartbeatManager.requestHeartbeat(resourceID, null);
}

/**
 * Heartbeat request from the job manager.
 *
 * @param heartbeatOrigin unique id of the job manager
 */
void heartbeatFromJobManager(ResourceID heartbeatOrigin);

/**
 * Heartbeat request from the resource manager.
 *
 * @param heartbeatOrigin unique id of the resource manager
 */
void heartbeatFromResourceManager(ResourceID heartbeatOrigin);

 

[Till Rohrmann]

The RPC methods `heartbeatFromXYZ` are the incoming heartbeats from the
JobMaster and ResourceManager, respectively. That's why they are called
heartbeatFrom. The TaskExecutor is only responding to heartbeat requests
but not actively sending them out.

Cheers,
Till

On Thu, Feb 8, 2018 at 1:06 PM, mingleizhang <[hidden email]> wrote:

> Attached is the taskmanager design picture. And from the picturen, I know
> taskmanager send heartbeat to jobmanager ( also called jobmaster in flip6
> now) and resourcesmanager periodically. But when I watched the source code
> below in TaskExecutor.java. I feel confused about the function name.
> Shouldn't it be *heartbeatToJobManager *and *heartbeatToResouceManager *?
> And in TaskExecutorGateway.java there is a comment, Heartbeat request from
> job manager. yea. both them confused me a lot. Does anyone let me know why
> called it like that ?
>
> Thanks
> Rice.
>
> // ----------------------------------------------------------------------
> // Heartbeat RPC
> // ----------------------------------------------------------------------
>
> @Override
> public void heartbeatFromJobManager(ResourceID resourceID) {
>    jobManagerHeartbeatManager.requestHeartbeat(resourceID, null);
> }
>
> @Override
> public void heartbeatFromResourceManager(ResourceID resourceID) {
>    resourceManagerHeartbeatManager.requestHeartbeat(resourceID, null);
> }
>
> /**
>  * Heartbeat request from the job manager.
>  *
>  * @param heartbeatOrigin unique id of the job manager
>  */
> void heartbeatFromJobManager(ResourceID heartbeatOrigin);
>
> /**
>  * Heartbeat request from the resource manager.
>  *
>  * @param heartbeatOrigin unique id of the resource manager
>  */
> void heartbeatFromResourceManager(ResourceID heartbeatOrigin);
>
>
>
>
>

[mingleizhang]

Thanks Till. But sorry, what what!  The TaskExecutor is only responding to heartbeat requests but not actively sending them out ? ? ? I think taskexecutor should report it's status to jobmanager and resourcemanager by heartbeat. And TaskExecutor is like a slave and jobmanager and resourcemanager are act as master.... That is what I think now. I am wrong ? Please! Strange....


Thanks
Rice.







At 2018-02-08 20:16:05, "Till Rohrmann" <[hidden email]> wrote:

>The RPC methods `heartbeatFromXYZ` are the incoming heartbeats from the
>JobMaster and ResourceManager, respectively. That's why they are called
>heartbeatFrom. The TaskExecutor is only responding to heartbeat requests
>but not actively sending them out.
>
>Cheers,
>Till
>
>On Thu, Feb 8, 2018 at 1:06 PM, mingleizhang <[hidden email]> wrote:
>
>> Attached is the taskmanager design picture. And from the picturen, I know
>> taskmanager send heartbeat to jobmanager ( also called jobmaster in flip6
>> now) and resourcesmanager periodically. But when I watched the source code
>> below in TaskExecutor.java. I feel confused about the function name.
>> Shouldn't it be *heartbeatToJobManager *and *heartbeatToResouceManager *?
>> And in TaskExecutorGateway.java there is a comment, Heartbeat request from
>> job manager. yea. both them confused me a lot. Does anyone let me know why
>> called it like that ?
>>
>> Thanks
>> Rice.
>>
>> // ----------------------------------------------------------------------
>> // Heartbeat RPC
>> // ----------------------------------------------------------------------
>>
>> @Override
>> public void heartbeatFromJobManager(ResourceID resourceID) {
>>    jobManagerHeartbeatManager.requestHeartbeat(resourceID, null);
>> }
>>
>> @Override
>> public void heartbeatFromResourceManager(ResourceID resourceID) {
>>    resourceManagerHeartbeatManager.requestHeartbeat(resourceID, null);
>> }
>>
>> /**
>>  * Heartbeat request from the job manager.
>>  *
>>  * @param heartbeatOrigin unique id of the job manager
>>  */
>> void heartbeatFromJobManager(ResourceID heartbeatOrigin);
>>
>> /**
>>  * Heartbeat request from the resource manager.
>>  *
>>  * @param heartbeatOrigin unique id of the resource manager
>>  */
>> void heartbeatFromResourceManager(ResourceID heartbeatOrigin);
>>
>>
>>
>>
>>

[Till Rohrmann]

Yes this is how it works. The TaskExecutor gets polled for its heartbeat
response if you wish. Of course, if it does not get polled often enough,
then the JobMaster or RM can also time out.

On Thu, Feb 8, 2018 at 1:22 PM, mingleizhang <[hidden email]> wrote:

> Thanks Till. But sorry, what what!  The TaskExecutor is only responding to
> heartbeat requests but not actively sending them out ? ? ? I think
> taskexecutor should report it's status to jobmanager and resourcemanager by
> heartbeat. And TaskExecutor is like a slave and jobmanager and
> resourcemanager are act as master.... That is what I think now. I am wrong
> ? Please! Strange....
>
> Thanks
> Rice.
>
>
>
>
>
> At 2018-02-08 20:16:05, "Till Rohrmann" <[hidden email]> wrote:
> >The RPC methods `heartbeatFromXYZ` are the incoming heartbeats from the
> >JobMaster and ResourceManager, respectively. That's why they are called
> >heartbeatFrom. The TaskExecutor is only responding to heartbeat requests
> >but not actively sending them out.
> >
> >Cheers,
> >Till
> >
> >On Thu, Feb 8, 2018 at 1:06 PM, mingleizhang <[hidden email]> wrote:
> >
> >> Attached is the taskmanager design picture. And from the picturen, I know
> >> taskmanager send heartbeat to jobmanager ( also called jobmaster in flip6
> >> now) and resourcesmanager periodically. But when I watched the source code
> >> below in TaskExecutor.java. I feel confused about the function name.
> >> Shouldn't it be *heartbeatToJobManager *and *heartbeatToResouceManager *?
> >> And in TaskExecutorGateway.java there is a comment, Heartbeat request from
> >> job manager. yea. both them confused me a lot. Does anyone let me know why
> >> called it like that ?
> >>
> >> Thanks
> >> Rice.
> >>
> >> // ----------------------------------------------------------------------
> >> // Heartbeat RPC
> >> // ----------------------------------------------------------------------
> >>
> >> @Override
> >> public void heartbeatFromJobManager(ResourceID resourceID) {
> >>    jobManagerHeartbeatManager.requestHeartbeat(resourceID, null);
> >> }
> >>
> >> @Override
> >> public void heartbeatFromResourceManager(ResourceID resourceID) {
> >>    resourceManagerHeartbeatManager.requestHeartbeat(resourceID, null);
> >> }
> >>
> >> /**
> >>  * Heartbeat request from the job manager.
> >>  *
> >>  * @param heartbeatOrigin unique id of the job manager
> >>  */
> >> void heartbeatFromJobManager(ResourceID heartbeatOrigin);
> >>
> >> /**
> >>  * Heartbeat request from the resource manager.
> >>  *
> >>  * @param heartbeatOrigin unique id of the resource manager
> >>  */
> >> void heartbeatFromResourceManager(ResourceID heartbeatOrigin);
> >>
> >>
> >>
> >>
> >>
>
>
>
>
>