Code renamed and adjusted to Apache Incubator guidelines

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Code renamed and adjusted to Apache Incubator guidelines

Stephan Ewen
Hi everyone!

As of today, the code in the master has been updated to use the name
"flink" instead of "stratosphere".

 - All code is in the namespace "org.apache.flink"
 - All maven projects are now "flink-*"
 - All comments, javadocs, markdown docs refer to "flink"
 - Source headers are adjusted to be ASF compliant
 - Notice, Readme, etc has been rewritten.
 - Shell scripts and commands use the name "flink"

Robert and me tried to do it very thoroughly. If we overlooked something,
please let us know.

Greetings,
Stephan
Reply | Threaded
Open this post in threaded view
|

Re: Code renamed and adjusted to Apache Incubator guidelines

Ufuk Celebi

On 12 Jul 2014, at 14:55, Stephan Ewen <[hidden email]> wrote:

> Hi everyone!
>
> As of today, the code in the master has been updated to use the name
> "flink" instead of "stratosphere".
>
> - All code is in the namespace "org.apache.flink"
> - All maven projects are now "flink-*"
> - All comments, javadocs, markdown docs refer to "flink"
> - Source headers are adjusted to be ASF compliant
> - Notice, Readme, etc has been rewritten.
> - Shell scripts and commands use the name "flink"
>
> Robert and me tried to do it very thoroughly. If we overlooked something,
> please let us know.

Thanks for taking care of this. Next step: first Apache release! :-)
Reply | Threaded
Open this post in threaded view
|

Re: Code renamed and adjusted to Apache Incubator guidelines

Henry Saputra
In reply to this post by Stephan Ewen
W00t! :)

On Saturday, July 12, 2014, Stephan Ewen <[hidden email]> wrote:

> Hi everyone!
>
> As of today, the code in the master has been updated to use the name
> "flink" instead of "stratosphere".
>
>  - All code is in the namespace "org.apache.flink"
>  - All maven projects are now "flink-*"
>  - All comments, javadocs, markdown docs refer to "flink"
>  - Source headers are adjusted to be ASF compliant
>  - Notice, Readme, etc has been rewritten.
>  - Shell scripts and commands use the name "flink"
>
> Robert and me tried to do it very thoroughly. If we overlooked something,
> please let us know.
>
> Greetings,
> Stephan
>
Reply | Threaded
Open this post in threaded view
|

Re: Code renamed and adjusted to Apache Incubator guidelines

Márton Balassi
A file search of "Stratosphere" on "*java" files in Eclipse still produces
36 hits. (They might be duplicated by the way as both flink-parent and
flink-<everything else> were included...)

Another related issue that might be worth to consider: I've noticed that
you've eliminated "nephele" from the package naming conventions. However it
is still in the code: mostly in variable names and comments - occuring
around 800 times for me. It might be a good point of time to get rid of
this if you are for eliminating the Nephele abstraction.


On Sat, Jul 12, 2014 at 7:44 PM, Henry Saputra <[hidden email]>
wrote:

> W00t! :)
>
> On Saturday, July 12, 2014, Stephan Ewen <[hidden email]> wrote:
>
> > Hi everyone!
> >
> > As of today, the code in the master has been updated to use the name
> > "flink" instead of "stratosphere".
> >
> >  - All code is in the namespace "org.apache.flink"
> >  - All maven projects are now "flink-*"
> >  - All comments, javadocs, markdown docs refer to "flink"
> >  - Source headers are adjusted to be ASF compliant
> >  - Notice, Readme, etc has been rewritten.
> >  - Shell scripts and commands use the name "flink"
> >
> > Robert and me tried to do it very thoroughly. If we overlooked something,
> > please let us know.
> >
> > Greetings,
> > Stephan
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Code renamed and adjusted to Apache Incubator guidelines

Stephan Ewen
Hi Marton!

I agree, cleaning up legacy names is desirable. I tend to do that on the
fly, in classes that I work on.

A dedicated swipe would take quite a lot of time, so we have not gotten
around to that so far.

Greetings,
Stephan
Reply | Threaded
Open this post in threaded view
|

Re: Code renamed and adjusted to Apache Incubator guidelines

Robert Metzger
I think the only "Stratosphere" references left in the code are URLs to the
old Github Account or the documentation for the 0.4 release. The
quickstart.sh script also still points to the 0.5.1 release, because it
always points to the last stable release.
If you have found references other than that, please tell me their names.

I agree with Stephan that we should remove the "Nephele" and "PACT" stuff
in a separate effort (low priority however ;) ). In my understanding, such
a change would not affect any user-facing APIs.


Robert


On Sun, Jul 13, 2014 at 2:57 PM, Stephan Ewen <[hidden email]> wrote:

> Hi Marton!
>
> I agree, cleaning up legacy names is desirable. I tend to do that on the
> fly, in classes that I work on.
>
> A dedicated swipe would take quite a lot of time, so we have not gotten
> around to that so far.
>
> Greetings,
> Stephan
>
Reply | Threaded
Open this post in threaded view
|

Re: Code renamed and adjusted to Apache Incubator guidelines

Márton Balassi
Double-checked Stratosphere, you're correct.

I also agree on legacy names, it is fine if they slowly but surely get
eliminated - thus noone has the inconvenient task to deal with them once. :)


On Sun, Jul 13, 2014 at 3:43 PM, Robert Metzger <[hidden email]> wrote:

> I think the only "Stratosphere" references left in the code are URLs to the
> old Github Account or the documentation for the 0.4 release. The
> quickstart.sh script also still points to the 0.5.1 release, because it
> always points to the last stable release.
> If you have found references other than that, please tell me their names.
>
> I agree with Stephan that we should remove the "Nephele" and "PACT" stuff
> in a separate effort (low priority however ;) ). In my understanding, such
> a change would not affect any user-facing APIs.
>
>
> Robert
>
>
> On Sun, Jul 13, 2014 at 2:57 PM, Stephan Ewen <[hidden email]> wrote:
>
> > Hi Marton!
> >
> > I agree, cleaning up legacy names is desirable. I tend to do that on the
> > fly, in classes that I work on.
> >
> > A dedicated swipe would take quite a lot of time, so we have not gotten
> > around to that so far.
> >
> > Greetings,
> > Stephan
> >
>