CiBot Update

[Chesnay Schepler-3]

Hello all,

on Thursday i pushed an update to the CiBot so that it

  * only maintains a single comment, updating it for each new build
  * also links in-progress/queued builds, instead of just finished ones.

The update also included a bug that causes the bot to not recognize
which commits have been verified before, which lead to a sharp increase
in queue times as it repeatedly scheduled builds for the same commit.
This issue has been fixed, all redundant builds have been removed from
the queue and all comments have been updated to point to previously
completed builds.

I apologize for the inconvenience.

[bowen.li]

  * only maintains a single comment, updating it for each new build
  * also links in-progress/queued builds, instead of just finished ones.

Want to clarify that the above changes still hold?



On Fri, Jul 12, 2019 at 3:56 PM Chesnay Schepler <[hidden email]> wrote:

> Hello all,
>
> on Thursday i pushed an update to the CiBot so that it
>
>   * only maintains a single comment, updating it for each new build
>   * also links in-progress/queued builds, instead of just finished ones.
>
> The update also included a bug that causes the bot to not recognize
> which commits have been verified before, which lead to a sharp increase
> in queue times as it repeatedly scheduled builds for the same commit.
> This issue has been fixed, all redundant builds have been removed from
> the queue and all comments have been updated to point to previously
> completed builds.
>
> I apologize for the inconvenience.
>
>

[Chesnay Schepler-3]

Yes.

On 13/07/2019 01:56, Bowen Li wrote:

>    * only maintains a single comment, updating it for each new build
>    * also links in-progress/queued builds, instead of just finished ones.
>
> Want to clarify that the above changes still hold?
>
>
>
> On Fri, Jul 12, 2019 at 3:56 PM Chesnay Schepler <[hidden email]> wrote:
>
>> Hello all,
>>
>> on Thursday i pushed an update to the CiBot so that it
>>
>>    * only maintains a single comment, updating it for each new build
>>    * also links in-progress/queued builds, instead of just finished ones.
>>
>> The update also included a bug that causes the bot to not recognize
>> which commits have been verified before, which lead to a sharp increase
>> in queue times as it repeatedly scheduled builds for the same commit.
>> This issue has been fixed, all redundant builds have been removed from
>> the queue and all comments have been updated to point to previously
>> completed builds.
>>
>> I apologize for the inconvenience.
>>
>>

[bowen.li]

Thanks Chesnay for the update.

A new issue I found is that our bot doesn't seem to update the final CI
status back to github.

E.g. in [1], the CI Report shows "d1aa3f2 : PENDING Build" at the moment,
but the travis build actually passed successfully 14 hours ago [2].

[1] https://github.com/apache/flink/pull/8920#issuecomment-510405859
[2] https://travis-ci.com/flink-ci/flink/builds/119001147



On Fri, Jul 12, 2019 at 11:00 PM Chesnay Schepler <[hidden email]>
wrote:

> Yes.
>
> On 13/07/2019 01:56, Bowen Li wrote:
> >    * only maintains a single comment, updating it for each new build
> >    * also links in-progress/queued builds, instead of just finished ones.
> >
> > Want to clarify that the above changes still hold?
> >
> >
> >
> > On Fri, Jul 12, 2019 at 3:56 PM Chesnay Schepler <[hidden email]>
> wrote:
> >
> >> Hello all,
> >>
> >> on Thursday i pushed an update to the CiBot so that it
> >>
> >>    * only maintains a single comment, updating it for each new build
> >>    * also links in-progress/queued builds, instead of just finished
> ones.
> >>
> >> The update also included a bug that causes the bot to not recognize
> >> which commits have been verified before, which lead to a sharp increase
> >> in queue times as it repeatedly scheduled builds for the same commit.
> >> This issue has been fixed, all redundant builds have been removed from
> >> the queue and all comments have been updated to point to previously
> >> completed builds.
> >>
> >> I apologize for the inconvenience.
> >>
> >>
>
>

[Chesnay Schepler-3]

The comment was updated in the mean-time.

On 13/07/2019 19:47, Bowen Li wrote:

> Thanks Chesnay for the update.
>
> A new issue I found is that our bot doesn't seem to update the final CI
> status back to github.
>
> E.g. in [1], the CI Report shows "d1aa3f2 : PENDING Build" at the moment,
> but the travis build actually passed successfully 14 hours ago [2].
>
> [1] https://github.com/apache/flink/pull/8920#issuecomment-510405859
> [2] https://travis-ci.com/flink-ci/flink/builds/119001147
>
>
>
> On Fri, Jul 12, 2019 at 11:00 PM Chesnay Schepler <[hidden email]>
> wrote:
>
>> Yes.
>>
>> On 13/07/2019 01:56, Bowen Li wrote:
>>>     * only maintains a single comment, updating it for each new build
>>>     * also links in-progress/queued builds, instead of just finished ones.
>>>
>>> Want to clarify that the above changes still hold?
>>>
>>>
>>>
>>> On Fri, Jul 12, 2019 at 3:56 PM Chesnay Schepler <[hidden email]>
>> wrote:
>>>> Hello all,
>>>>
>>>> on Thursday i pushed an update to the CiBot so that it
>>>>
>>>>     * only maintains a single comment, updating it for each new build
>>>>     * also links in-progress/queued builds, instead of just finished
>> ones.
>>>> The update also included a bug that causes the bot to not recognize
>>>> which commits have been verified before, which lead to a sharp increase
>>>> in queue times as it repeatedly scheduled builds for the same commit.
>>>> This issue has been fixed, all redundant builds have been removed from
>>>> the queue and all comments have been updated to point to previously
>>>> completed builds.
>>>>
>>>> I apologize for the inconvenience.
>>>>
>>>>
>>