Change build-target to a specific folder

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Change build-target to a specific folder

mingleizhang
Hi,


Anyway, the line of cd build-target  below confused me for a while at the first time since there is not a folder called build-target. So I would suggest change this stuff to a more reasonable representation for the beginner to flink.
What do you think of that ?


Like
cd flink-dist/target/flink-{version}-SNAPSHOT-bin/flink-{version}-SNAPSHOT


Thanks
Minglei
Download and Compile

Clone the source code from one of our repositories, e.g.:

$ git clone https://github.com/apache/flink.git
$ cd flink
$ mvn clean package -DskipTests# this will take up to 10 minutes$ cd build-target               # this is where Flink is installed to





Reply | Threaded
Open this post in threaded view
|

Re: Change build-target to a specific folder

Aljoscha Krettek-2
Is this from the "building Flink" quickstart? I don't mind too much but you can open a PR if you want to change that.

> On 9. Mar 2018, at 08:00, mingleizhang <[hidden email]> wrote:
>
> Hi,
>
>
> Anyway, the line of cd build-target  below confused me for a while at the first time since there is not a folder called build-target. So I would suggest change this stuff to a more reasonable representation for the beginner to flink.
> What do you think of that ?
>
>
> Like
> cd flink-dist/target/flink-{version}-SNAPSHOT-bin/flink-{version}-SNAPSHOT
>
>
> Thanks
> Minglei
> Download and Compile
>
> Clone the source code from one of our repositories, e.g.:
>
> $ git clone https://github.com/apache/flink.git
> $ cd flink
> $ mvn clean package -DskipTests# this will take up to 10 minutes$ cd build-target               # this is where Flink is installed to
>
>
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re:Re: Change build-target to a specific folder

mingleizhang
Yes. It is. and I might do a little change for this.






At 2018-03-09 17:35:42, "Aljoscha Krettek" <[hidden email]> wrote:

>Is this from the "building Flink" quickstart? I don't mind too much but you can open a PR if you want to change that.
>
>> On 9. Mar 2018, at 08:00, mingleizhang <[hidden email]> wrote:
>>
>> Hi,
>>
>>
>> Anyway, the line of cd build-target  below confused me for a while at the first time since there is not a folder called build-target. So I would suggest change this stuff to a more reasonable representation for the beginner to flink.
>> What do you think of that ?
>>
>>
>> Like
>> cd flink-dist/target/flink-{version}-SNAPSHOT-bin/flink-{version}-SNAPSHOT
>>
>>
>> Thanks
>> Minglei
>> Download and Compile
>>
>> Clone the source code from one of our repositories, e.g.:
>>
>> $ git clone https://github.com/apache/flink.git
>> $ cd flink
>> $ mvn clean package -DskipTests# this will take up to 10 minutes$ cd build-target               # this is where Flink is installed to
>>
>>
>>
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: Re: Change build-target to a specific folder

Stephan Ewen
There should be a ' build-target' folder created when 'flink-dist' is
built. (actually, a symlink, more precisely)

If will not work on Windows, through. Are you running Windows?

On Fri, Mar 9, 2018 at 11:34 AM, mingleizhang <[hidden email]>
wrote:

> Yes. It is. and I might do a little change for this.
>
>
>
>
>
>
> At 2018-03-09 17:35:42, "Aljoscha Krettek" <[hidden email]> wrote:
> >Is this from the "building Flink" quickstart? I don't mind too much but
> you can open a PR if you want to change that.
> >
> >> On 9. Mar 2018, at 08:00, mingleizhang <[hidden email]> wrote:
> >>
> >> Hi,
> >>
> >>
> >> Anyway, the line of cd build-target  below confused me for a while at
> the first time since there is not a folder called build-target. So I would
> suggest change this stuff to a more reasonable representation for the
> beginner to flink.
> >> What do you think of that ?
> >>
> >>
> >> Like
> >> cd flink-dist/target/flink-{version}-SNAPSHOT-bin/flink-{
> version}-SNAPSHOT
> >>
> >>
> >> Thanks
> >> Minglei
> >> Download and Compile
> >>
> >> Clone the source code from one of our repositories, e.g.:
> >>
> >> $ git clone https://github.com/apache/flink.git
> >> $ cd flink
> >> $ mvn clean package -DskipTests# this will take up to 10 minutes$ cd
> build-target               # this is where Flink is installed to
> >>
> >>
> >>
> >>
> >>
>
Reply | Threaded
Open this post in threaded view
|

Re:Re: Re: Change build-target to a specific folder

mingleizhang

Yes. I am running on windows. So, I can not see a folder called build-target under flink-dist  ?







At 2018-03-09 19:01:44, "Stephan Ewen" <[hidden email]> wrote:

>There should be a ' build-target' folder created when 'flink-dist' is
>built. (actually, a symlink, more precisely)
>
>If will not work on Windows, through. Are you running Windows?
>
>On Fri, Mar 9, 2018 at 11:34 AM, mingleizhang <[hidden email]>
>wrote:
>
>> Yes. It is. and I might do a little change for this.
>>
>>
>>
>>
>>
>>
>> At 2018-03-09 17:35:42, "Aljoscha Krettek" <[hidden email]> wrote:
>> >Is this from the "building Flink" quickstart? I don't mind too much but
>> you can open a PR if you want to change that.
>> >
>> >> On 9. Mar 2018, at 08:00, mingleizhang <[hidden email]> wrote:
>> >>
>> >> Hi,
>> >>
>> >>
>> >> Anyway, the line of cd build-target  below confused me for a while at
>> the first time since there is not a folder called build-target. So I would
>> suggest change this stuff to a more reasonable representation for the
>> beginner to flink.
>> >> What do you think of that ?
>> >>
>> >>
>> >> Like
>> >> cd flink-dist/target/flink-{version}-SNAPSHOT-bin/flink-{
>> version}-SNAPSHOT
>> >>
>> >>
>> >> Thanks
>> >> Minglei
>> >> Download and Compile
>> >>
>> >> Clone the source code from one of our repositories, e.g.:
>> >>
>> >> $ git clone https://github.com/apache/flink.git
>> >> $ cd flink
>> >> $ mvn clean package -DskipTests# this will take up to 10 minutes$ cd
>> build-target               # this is where Flink is installed to
>> >>
>> >>
>> >>
>> >>
>> >>
>>
Reply | Threaded
Open this post in threaded view
|

Re: Change build-target to a specific folder

Chesnay Schepler-3
The build-target directory is not generated on Windows. We disabled that
at some point; don't quite remember why.

On 09.03.2018 13:13, mingleizhang wrote:

> Yes. I am running on windows. So, I can not see a folder called build-target under flink-dist  ?
>
>
>
>
>
>
>
> At 2018-03-09 19:01:44, "Stephan Ewen" <[hidden email]> wrote:
>> There should be a ' build-target' folder created when 'flink-dist' is
>> built. (actually, a symlink, more precisely)
>>
>> If will not work on Windows, through. Are you running Windows?
>>
>> On Fri, Mar 9, 2018 at 11:34 AM, mingleizhang <[hidden email]>
>> wrote:
>>
>>> Yes. It is. and I might do a little change for this.
>>>
>>>
>>>
>>>
>>>
>>>
>>> At 2018-03-09 17:35:42, "Aljoscha Krettek" <[hidden email]> wrote:
>>>> Is this from the "building Flink" quickstart? I don't mind too much but
>>> you can open a PR if you want to change that.
>>>>> On 9. Mar 2018, at 08:00, mingleizhang <[hidden email]> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>>
>>>>> Anyway, the line of cd build-target  below confused me for a while at
>>> the first time since there is not a folder called build-target. So I would
>>> suggest change this stuff to a more reasonable representation for the
>>> beginner to flink.
>>>>> What do you think of that ?
>>>>>
>>>>>
>>>>> Like
>>>>> cd flink-dist/target/flink-{version}-SNAPSHOT-bin/flink-{
>>> version}-SNAPSHOT
>>>>>
>>>>> Thanks
>>>>> Minglei
>>>>> Download and Compile
>>>>>
>>>>> Clone the source code from one of our repositories, e.g.:
>>>>>
>>>>> $ git clone https://github.com/apache/flink.git
>>>>> $ cd flink
>>>>> $ mvn clean package -DskipTests# this will take up to 10 minutes$ cd
>>> build-target               # this is where Flink is installed to
>>>>>
>>>>>
>>>>>
>>>>>

Reply | Threaded
Open this post in threaded view
|

Re: Change build-target to a specific folder

Stephan Ewen
The original code that created the directory used an unsafe plugin. The new
way to add it unfortunately works only on UNIX.

Checkout the "flink-dist"/pom.xml file where the directory is created:
https://github.com/apache/flink/blob/master/flink-dist/pom.xml#L415

If you can find a way to make this work on Windows as well, would be great
if you could contribute a patch.


On Fri, Mar 9, 2018 at 4:10 PM, Chesnay Schepler <[hidden email]> wrote:

> The build-target directory is not generated on Windows. We disabled that
> at some point; don't quite remember why.
>
>
> On 09.03.2018 13:13, mingleizhang wrote:
>
>> Yes. I am running on windows. So, I can not see a folder called
>> build-target under flink-dist  ?
>>
>>
>>
>>
>>
>>
>>
>> At 2018-03-09 19:01:44, "Stephan Ewen" <[hidden email]> wrote:
>>
>>> There should be a ' build-target' folder created when 'flink-dist' is
>>> built. (actually, a symlink, more precisely)
>>>
>>> If will not work on Windows, through. Are you running Windows?
>>>
>>> On Fri, Mar 9, 2018 at 11:34 AM, mingleizhang <[hidden email]>
>>> wrote:
>>>
>>> Yes. It is. and I might do a little change for this.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> At 2018-03-09 17:35:42, "Aljoscha Krettek" <[hidden email]> wrote:
>>>>
>>>>> Is this from the "building Flink" quickstart? I don't mind too much but
>>>>>
>>>> you can open a PR if you want to change that.
>>>>
>>>>> On 9. Mar 2018, at 08:00, mingleizhang <[hidden email]> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>>
>>>>>> Anyway, the line of cd build-target  below confused me for a while at
>>>>>>
>>>>> the first time since there is not a folder called build-target. So I
>>>> would
>>>> suggest change this stuff to a more reasonable representation for the
>>>> beginner to flink.
>>>>
>>>>> What do you think of that ?
>>>>>>
>>>>>>
>>>>>> Like
>>>>>> cd flink-dist/target/flink-{version}-SNAPSHOT-bin/flink-{
>>>>>>
>>>>> version}-SNAPSHOT
>>>>
>>>>>
>>>>>> Thanks
>>>>>> Minglei
>>>>>> Download and Compile
>>>>>>
>>>>>> Clone the source code from one of our repositories, e.g.:
>>>>>>
>>>>>> $ git clone https://github.com/apache/flink.git
>>>>>> $ cd flink
>>>>>> $ mvn clean package -DskipTests# this will take up to 10 minutes$ cd
>>>>>>
>>>>> build-target               # this is where Flink is installed to
>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>