[CANCELLED][VOTE] Release Apache Flink 1.2.0 (RC1)

[Robert Metzger]

Thank you for checking the licenses and fixing it already Stephan!

@Chesnay: I think we just have to mention it in the LICENSE file, then we
are good to use it.

*I will cancel this release candidate then and create RC2 at 6pm CET
(roughly in 4 hours) today.*
We can use these 4 hours to fix the issue Stefan mentioned (
https://issues.apache.org/jira/browse/FLINK-5602).
It has already a pull request.

I found three minor issues while testing:
- Incorrect log message during TM startup due to https://issues.apache.org/j
ira/browse/FLINK-5492
- Parser WARNings in the log: https://issues.apache.
org/jira/browse/FLINK-5637
- https://issues.apache.org/jira/browse/FLINK-5641

It would be nice if we could fix them as well.



On Wed, Jan 25, 2017 at 1:59 PM, Chesnay Schepler <[hidden email]>
wrote:

> As far as i know this is only used on the metrics page, so we could remove
> it temporarily until we found a replacement.
> This wouldn't remove functionality that existed before 1.2.
>
>
> On 25.01.2017 13:50, Stephan Ewen wrote:
>
>> The angular-drag-and-drop-list
>>
>> https://github.com/apache/flink/commit/34e106f63c9dcd2673d66
>> b47fda1555b7dced770
>>
>>
>>
>> On Wed, Jan 25, 2017 at 1:48 PM, Chesnay Schepler <[hidden email]>
>> wrote:
>>
>> Which dependency is MIT?
>>>
>>>
>>> On 25.01.2017 13:24, Stephan Ewen wrote:
>>>
>>> Did a License cross-check:
>>>>
>>>> All Maven Dependencies are okay. Added a small note on the RabbitMQ
>>>> dependency's MPL 1.1 implications
>>>>
>>>> The Web UI added three new dependencies which are source-bundled since
>>>> the
>>>> last release
>>>>     - One was added to the license file
>>>>     - One is ASL 2.0 (no license update needed)
>>>>
>>>>     => One is MIT and reference in the License is missing
>>>>
>>>> I think we have a release blocker here :-(
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Wed, Jan 25, 2017 at 11:12 AM, Chesnay Schepler <[hidden email]>
>>>> wrote:
>>>>
>>>> Hello,
>>>>
>>>>> FLINK-5612 might be a blocker as well; basically if you use the
>>>>> GlobFilePathFilter in a job, chances are it will fail.
>>>>>
>>>>> Also, the lastCheckpointSize metric that we collect for each task was
>>>>> broken when the key-groups were introduced.
>>>>>
>>>>> Regards,
>>>>> Chesnay
>>>>>
>>>>>
>>>>> On 25.01.2017 10:52, Stefan Richter wrote:
>>>>>
>>>>> Hi Robert,
>>>>>
>>>>>> I found an potientally blocking issue in RC1 that I would like to
>>>>>> bring
>>>>>> up for debate. In [FLINK-5602], Ufuk found a NPE that happened during
>>>>>> the
>>>>>> first checkpoint after migrating a job from Flink 1.1 to 1.2. I looked
>>>>>> into
>>>>>> this and found that the cause of this problem is the absense of
>>>>>> namespace
>>>>>> serializers in Flink 1.1 checkpoints. Flink 1.2 always makes all
>>>>>> serializers part of the checkpoint and therefore a precondition to
>>>>>> checkpointing fails if a checkpoint runs before the user code is
>>>>>> delivering
>>>>>> the namespace serializer. This is a race condition that (depending on
>>>>>> the
>>>>>> user code) could fail almost deterministcally in some situations (e.g.
>>>>>> user
>>>>>> is registering the state rather late). The consequence is that
>>>>>> checkpointing (and the whole job) fails in this scenario and
>>>>>> potentially
>>>>>> prevents user from upgrading to 1.2. I have a open PR #3200 that is
>>>>>> fixing
>>>>>> this problem.
>>>>>>
>>>>>> Best,
>>>>>> Stefan
>>>>>>
>>>>>> Am 24.01.2017 um 15:03 schrieb Robert Metzger <[hidden email]>:
>>>>>>
>>>>>> Dear Flink community,
>>>>>>>
>>>>>>> Please vote on releasing the following candidate as Apache Flink
>>>>>>> version
>>>>>>> 1.2.0.
>>>>>>>
>>>>>>> The commit to be voted on:
>>>>>>> 1bca1208 (*http://git-wip-us.apache.org
>>>>>>> /repos/asf/flink/commit/1bca12
>>>>>>> 08
>>>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/1bca1208>*)
>>>>>>>
>>>>>>> Branch:
>>>>>>> release-1.2.0-rc1
>>>>>>> (https://git1-us-west.apache.org/repos/asf/flink/repo?p=
>>>>>>> flink.git;a=shortlog;h=refs/heads/release-1.2.0-rc1)
>>>>>>>
>>>>>>> The release artifacts to be voted on can be found at:
>>>>>>> *http://people.apache.org/~rmetzger/flink-1.2.0-rc1/
>>>>>>> <http://people.apache.org/~rmetzger/flink-1.2.0-rc1/>*
>>>>>>>
>>>>>>> The release artifacts are signed with the key with fingerprint
>>>>>>> D9839159:
>>>>>>> http://www.apache.org/dist/flink/KEYS
>>>>>>>
>>>>>>> The staging repository for this release can be found at:
>>>>>>> https://repository.apache.org/content/repositories/orgapache
>>>>>>> flink-1112
>>>>>>>
>>>>>>> -------------------------------------------------------------
>>>>>>>
>>>>>>> The vote ends in three days (3 pm CET | Friday, January 27, 2017)
>>>>>>>
>>>>>>> Please test the release rather now than on Friday morning, to be able
>>>>>>> to
>>>>>>> cancel it as early as possible.
>>>>>>> For making the testing easier, I've created this document to track
>>>>>>> what
>>>>>>> has
>>>>>>> already been tested and what needs to be tested:
>>>>>>> https://docs.google.com/document/d/1MX-8l9RrLly3UmZMODHBnuZU
>>>>>>> rK_n-DGIBLjFKyCrTAs/edit?usp=sharing
>>>>>>> Feel free to add more tests or change existing ones.
>>>>>>>
>>>>>>> [ ] +1 Release this package as Apache Flink 1.2.0
>>>>>>> [ ] -1 Do not release this package, because ...
>>>>>>>
>>>>>>>
>>>>>>>
>

[Robert Metzger]

Looks like nobody objected my plans :)

I'm going to create a new RC for 1.2.0 now.

On Wed, Jan 25, 2017 at 2:13 PM, Robert Metzger <[hidden email]> wrote:

> Thank you for checking the licenses and fixing it already Stephan!
>
> @Chesnay: I think we just have to mention it in the LICENSE file, then we
> are good to use it.
>
> *I will cancel this release candidate then and create RC2 at 6pm CET
> (roughly in 4 hours) today.*
> We can use these 4 hours to fix the issue Stefan mentioned (
> https://issues.apache.org/jira/browse/FLINK-5602).
> It has already a pull request.
>
> I found three minor issues while testing:
> - Incorrect log message during TM startup due to
> https://issues.apache.org/jira/browse/FLINK-5492
> - Parser WARNings in the log: https://issues.apache.org
> /jira/browse/FLINK-5637
> - https://issues.apache.org/jira/browse/FLINK-5641
>
> It would be nice if we could fix them as well.
>
>
>
> On Wed, Jan 25, 2017 at 1:59 PM, Chesnay Schepler <[hidden email]>
> wrote:
>
>> As far as i know this is only used on the metrics page, so we could
>> remove it temporarily until we found a replacement.
>> This wouldn't remove functionality that existed before 1.2.
>>
>>
>> On 25.01.2017 13:50, Stephan Ewen wrote:
>>
>>> The angular-drag-and-drop-list
>>>
>>> https://github.com/apache/flink/commit/34e106f63c9dcd2673d66
>>> b47fda1555b7dced770
>>>
>>>
>>>
>>> On Wed, Jan 25, 2017 at 1:48 PM, Chesnay Schepler <[hidden email]>
>>> wrote:
>>>
>>> Which dependency is MIT?
>>>>
>>>>
>>>> On 25.01.2017 13:24, Stephan Ewen wrote:
>>>>
>>>> Did a License cross-check:
>>>>>
>>>>> All Maven Dependencies are okay. Added a small note on the RabbitMQ
>>>>> dependency's MPL 1.1 implications
>>>>>
>>>>> The Web UI added three new dependencies which are source-bundled since
>>>>> the
>>>>> last release
>>>>>     - One was added to the license file
>>>>>     - One is ASL 2.0 (no license update needed)
>>>>>
>>>>>     => One is MIT and reference in the License is missing
>>>>>
>>>>> I think we have a release blocker here :-(
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Jan 25, 2017 at 11:12 AM, Chesnay Schepler <[hidden email]
>>>>> >
>>>>> wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>>> FLINK-5612 might be a blocker as well; basically if you use the
>>>>>> GlobFilePathFilter in a job, chances are it will fail.
>>>>>>
>>>>>> Also, the lastCheckpointSize metric that we collect for each task was
>>>>>> broken when the key-groups were introduced.
>>>>>>
>>>>>> Regards,
>>>>>> Chesnay
>>>>>>
>>>>>>
>>>>>> On 25.01.2017 10:52, Stefan Richter wrote:
>>>>>>
>>>>>> Hi Robert,
>>>>>>
>>>>>>> I found an potientally blocking issue in RC1 that I would like to
>>>>>>> bring
>>>>>>> up for debate. In [FLINK-5602], Ufuk found a NPE that happened during
>>>>>>> the
>>>>>>> first checkpoint after migrating a job from Flink 1.1 to 1.2. I
>>>>>>> looked
>>>>>>> into
>>>>>>> this and found that the cause of this problem is the absense of
>>>>>>> namespace
>>>>>>> serializers in Flink 1.1 checkpoints. Flink 1.2 always makes all
>>>>>>> serializers part of the checkpoint and therefore a precondition to
>>>>>>> checkpointing fails if a checkpoint runs before the user code is
>>>>>>> delivering
>>>>>>> the namespace serializer. This is a race condition that (depending on
>>>>>>> the
>>>>>>> user code) could fail almost deterministcally in some situations
>>>>>>> (e.g.
>>>>>>> user
>>>>>>> is registering the state rather late). The consequence is that
>>>>>>> checkpointing (and the whole job) fails in this scenario and
>>>>>>> potentially
>>>>>>> prevents user from upgrading to 1.2. I have a open PR #3200 that is
>>>>>>> fixing
>>>>>>> this problem.
>>>>>>>
>>>>>>> Best,
>>>>>>> Stefan
>>>>>>>
>>>>>>> Am 24.01.2017 um 15:03 schrieb Robert Metzger <[hidden email]>:
>>>>>>>
>>>>>>> Dear Flink community,
>>>>>>>>
>>>>>>>> Please vote on releasing the following candidate as Apache Flink
>>>>>>>> version
>>>>>>>> 1.2.0.
>>>>>>>>
>>>>>>>> The commit to be voted on:
>>>>>>>> 1bca1208 (*http://git-wip-us.apache.org
>>>>>>>> /repos/asf/flink/commit/1bca12
>>>>>>>> 08
>>>>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/1bca1208>*)
>>>>>>>>
>>>>>>>> Branch:
>>>>>>>> release-1.2.0-rc1
>>>>>>>> (https://git1-us-west.apache.org/repos/asf/flink/repo?p=
>>>>>>>> flink.git;a=shortlog;h=refs/heads/release-1.2.0-rc1)
>>>>>>>>
>>>>>>>> The release artifacts to be voted on can be found at:
>>>>>>>> *http://people.apache.org/~rmetzger/flink-1.2.0-rc1/
>>>>>>>> <http://people.apache.org/~rmetzger/flink-1.2.0-rc1/>*
>>>>>>>>
>>>>>>>> The release artifacts are signed with the key with fingerprint
>>>>>>>> D9839159:
>>>>>>>> http://www.apache.org/dist/flink/KEYS
>>>>>>>>
>>>>>>>> The staging repository for this release can be found at:
>>>>>>>> https://repository.apache.org/content/repositories/orgapache
>>>>>>>> flink-1112
>>>>>>>>
>>>>>>>> -------------------------------------------------------------
>>>>>>>>
>>>>>>>> The vote ends in three days (3 pm CET | Friday, January 27, 2017)
>>>>>>>>
>>>>>>>> Please test the release rather now than on Friday morning, to be
>>>>>>>> able
>>>>>>>> to
>>>>>>>> cancel it as early as possible.
>>>>>>>> For making the testing easier, I've created this document to track
>>>>>>>> what
>>>>>>>> has
>>>>>>>> already been tested and what needs to be tested:
>>>>>>>> https://docs.google.com/document/d/1MX-8l9RrLly3UmZMODHBnuZU
>>>>>>>> rK_n-DGIBLjFKyCrTAs/edit?usp=sharing
>>>>>>>> Feel free to add more tests or change existing ones.
>>>>>>>>
>>>>>>>> [ ] +1 Release this package as Apache Flink 1.2.0
>>>>>>>> [ ] -1 Do not release this package, because ...
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>
>