Am I forgetting to do something to get pull request accepted?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Am I forgetting to do something to get pull request accepted?

jpcarterara@gmail.com
I just want to make sure I am not missing anything to get my pull request accepted. All tests are passing so I figured it was going to be a short time after that. Is there anything else that I need to do or a reason like there is a freeze on accepting pull requests for the moment? Here is the link to it in Travis IO: https://travis-ci.org/Jicaar/flink/builds/386283019
Reply | Threaded
Open this post in threaded view
|

Re: Am I forgetting to do something to get pull request accepted?

Chesnay Schepler-3
The Flink project currently receives too many pull requests / has to few
reviewers to ensure timely reviews.

I assume you are talking about https://github.com/apache/flink/pull/5876
If this is correct, something you could already do is squash all commits
and rebase against master to get rid of the merge commits.
The new InputFormat also shares a lot of code with the existing
CassandraOutputFormat. Shared portions could be moved in abstract
CassandraInputFormatBase class.

On 20.06.2018 20:50, [hidden email] wrote:
> I just want to make sure I am not missing anything to get my pull request accepted. All tests are passing so I figured it was going to be a short time after that. Is there anything else that I need to do or a reason like there is a freeze on accepting pull requests for the moment? Here is the link to it in Travis IO: https://travis-ci.org/Jicaar/flink/builds/386283019
>

Reply | Threaded
Open this post in threaded view
|

Re: Am I forgetting to do something to get pull request accepted?

jpcarterara@gmail.com
Ok, thanks!

On Thu, Jun 21, 2018, 1:18 AM Chesnay Schepler <[hidden email]> wrote:

> The Flink project currently receives too many pull requests / has to few
> reviewers to ensure timely reviews.
>
> I assume you are talking about https://github.com/apache/flink/pull/5876
> If this is correct, something you could already do is squash all commits
> and rebase against master to get rid of the merge commits.
> The new InputFormat also shares a lot of code with the existing
> CassandraOutputFormat. Shared portions could be moved in abstract
> CassandraInputFormatBase class.
>
> On 20.06.2018 20:50, [hidden email] wrote:
> > I just want to make sure I am not missing anything to get my pull
> request accepted. All tests are passing so I figured it was going to be a
> short time after that. Is there anything else that I need to do or a reason
> like there is a freeze on accepting pull requests for the moment? Here is
> the link to it in Travis IO:
> https://travis-ci.org/Jicaar/flink/builds/386283019
> >
>
>