A question about RocksDBListState and RocksDBMapState.

[kaka chen]

Hi All,

I noticed RocksDBListState and RocksDBMapState have both the following
comments:

* <p>{@link RocksDBStateBackend} must ensure that we set the
* {@link org.rocksdb.StringAppendOperator} on the column family that
we use for our state since
* we use the {@code merge()} call.


However, from the source code, I found only RocksDBListState use
rocksdb::merge() function which used StringAppendTestOperator in rocksdb to
merge the list entries when compaction or getting key. I don't know why
RocksDBMapState is related with these comments, could someone to explain
it, thanks.

Thanks,
Kaka

[Yun Tang]

Hi kaka

You're correct, these comments are not correct for RocksDBMapState now, will correct it with a hotfix.

Best
Yun Tang
________________________________
From: kaka chen <[hidden email]>
Sent: Friday, July 5, 2019 15:05
To: [hidden email]
Subject: A question about RocksDBListState and RocksDBMapState.

Hi All,

I noticed RocksDBListState and RocksDBMapState have both the following
comments:

* <p>{@link RocksDBStateBackend} must ensure that we set the
* {@link org.rocksdb.StringAppendOperator} on the column family that
we use for our state since
* we use the {@code merge()} call.


However, from the source code, I found only RocksDBListState use
rocksdb::merge() function which used StringAppendTestOperator in rocksdb to
merge the list entries when compaction or getting key. I don't know why
RocksDBMapState is related with these comments, could someone to explain
it, thanks.

Thanks,
Kaka

[kaka chen]

Hi Yun,

Thanks you for your clarification.

Thanks,
Kaka Chen



Yun Tang <[hidden email]> 于2019年7月5日周五 下午3:34写道：

> Hi kaka
>
> You're correct, these comments are not correct for RocksDBMapState now,
> will correct it with a hotfix.
>
> Best
> Yun Tang
> ________________________________
> From: kaka chen <[hidden email]>
> Sent: Friday, July 5, 2019 15:05
> To: [hidden email]
> Subject: A question about RocksDBListState and RocksDBMapState.
>
> Hi All,
>
> I noticed RocksDBListState and RocksDBMapState have both the following
> comments:
>
> * <p>{@link RocksDBStateBackend} must ensure that we set the
> * {@link org.rocksdb.StringAppendOperator} on the column family that
> we use for our state since
> * we use the {@code merge()} call.
>
>
> However, from the source code, I found only RocksDBListState use
> rocksdb::merge() function which used StringAppendTestOperator in rocksdb to
> merge the list entries when compaction or getting key. I don't know why
> RocksDBMapState is related with these comments, could someone to explain
> it, thanks.
>
> Thanks,
> Kaka
>